Add PyDABs support for SQL Alerts - #6335
Draft
Sankalp-Mittal wants to merge 6 commits into
Draft
Conversation
Sankalp-Mittal
changed the title
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -0,0 +1,19 @@ | |||
| from enum import Enum | |||
Collaborator
Author
There was a problem hiding this comment.
This entire directory _models/ is autogenerated
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -0,0 +1,123 @@ | |||
| __all__ = [ | |||
Collaborator
Author
There was a problem hiding this comment.
This file is also auto generated
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -12,6 +12,7 @@ | |||
| "VariableOrDict", | |||
Collaborator
Author
There was a problem hiding this comment.
These had to be manually added to add mutators
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -69,6 +70,38 @@ def my_job_mutator(bundle: Bundle, job: Job) -> Job: | |||
| # was deemed overly implicit and potentially confusing. | |||
|
|
|||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
Again manually added but standard template code
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -31,6 +31,7 @@ def all(cls) -> tuple["_ResourceType", ...]: | |||
| # intentionally lazily load all resource types to avoid imports from databricks.bundles.core to | |||
| # be imported in databricks.bundles.<resource_type> | |||
|
|
|||
Collaborator
Author
There was a problem hiding this comment.
This file should also be autogenerated we should just have a cli interface where singular and plural can be defined
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -249,6 +258,34 @@ def add_volume( | |||
|
|
|||
| self._volumes[resource_name] = volume | |||
|
|
|||
| def add_alert( | |||
Collaborator
Author
There was a problem hiding this comment.
This is the only function that I'm not sure on whether to autogenerate or not??
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -74,6 +83,40 @@ class TestCase: | |||
| ), | |||
| resource_types[Schema], | |||
| ), | |||
| ( | |||
Collaborator
Author
There was a problem hiding this comment.
This is the unit test params that I think need to be manually written
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -26,6 +34,7 @@ class TestCase: | |||
| dict_example: dict | |||
| dataclass_example: Resource | |||
| mutator: Callable | |||
| article: str = "a" # grammatical article in the duplicate-resource error message | |||
Collaborator
Author
There was a problem hiding this comment.
Default article can be overriden for example in the case of alert
Sankalp-Mittal
commented
Aug 20, 2026
| @@ -21,6 +22,8 @@ | |||
| "pipelines", | |||
| "resources", | |||
| "catalog", | |||
| "sql", | |||
Collaborator
Author
There was a problem hiding this comment.
These 2 had to be added manually but I think they can be found out using BFS and potentially stored in a yaml file
Collaborator
Integration test reportCommit: d3e7d64
Top 6 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP