Enable dashboards as part of workspace export-dir command - #6332
Open
janniklasrose wants to merge 4 commits into
Open
Enable dashboards as part of workspace export-dir command#6332janniklasrose wants to merge 4 commits into
janniklasrose wants to merge 4 commits into
Conversation
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
Collaborator
Integration test reportCommit: dd00af3
Top 6 slowest tests (at least 2 minutes):
|
The test diffed the exported dashboard against the exact input JSON, but the Lakeview backend normalizes the serialized dashboard on create (e.g. it drops an empty "layout": []). The local testserver echoes the input verbatim, so the test passed locally but failed on every real workspace. Assert the dashboard file was exported instead of diffing its content. This is what the change under test actually verifies (dashboards are no longer skipped by export-dir). Dropping the diff also removes the diff.py call that MSYS_NO_PATHCONV broke on Windows. Gate the test off Windows: export-dir prints the local destination with OS-native separators, which is incidental to the OS-independent export behavior being tested. Co-authored-by: Isaac
…ce-export-dir-with-dashboards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Enable dashboards as part of the
workspace export-dircommandWhy
The export API actually supports dashboards, but was previously marked as unsupported.
Tests
Tested locally.
Also added a cloud acceptance test.