Bump databricks-sdk-go from v0.171.0 to v0.175.0 - #6322
Open
shreyas-goenka wants to merge 3 commits into
Open
Conversation
Bump the pinned SDK and OpenAPI spec SHA, and regenerate all downstream artifacts. Breaking changes handled: - jobs.JobCluster.NewCluster became *compute.ClusterSpec (v0.172): nil-guard the job-cluster fixups and update the affected test fixtures. - pipelines.GetPipelineResponse gained EffectiveServerlessComputeId: add it to PipelineRemote so TestPipelineRemote's coverage check passes. - apps.App absorbed source_code_path, git_source, and default_git_source (v0.175), duplicating the json tags DABs already declared on resources.App, AppState, and AppRemote. Two fields at one path broke app diffing (phantom source_code_path drift plus an "unexpected local and remote diffs" warning), so drop the DABs copies and use the embedded ones. The bundle key source_code_path is unchanged for users, and appRequestBody keeps these deploy-only fields out of app create/update bodies as before. Remote-side suppression now comes from the spec (input_only/output_only) via resources.generated.yml. Co-authored-by: Isaac
Co-authored-by: Isaac
The v0.175 spec no longer annotates serving telemetry_config.table_names as input_only, so resources.generated.yml stopped emitting the rule and the field became permanent drift: the backend consumes table_names to provision a profile and never returns it, so bundle plan never converged for a model serving endpoint with telemetry_config. Restore the hand-written rule that the v0.171 spec had made redundant. Co-authored-by: Isaac
shreyas-goenka
marked this pull request as ready for review
August 19, 2026 16:06
Contributor
Approval status: pending
|
Collaborator
Integration test reportCommit: 9927802
8 interesting tests: 4 SKIP, 3 RECOVERED, 1 KNOWN
Top 10 slowest tests (at least 2 minutes):
|
shreyas-goenka
requested review from
andrewnester,
denik and
pietern
and removed request for
andrewnester and
pietern
August 20, 2026 08:52
shreyas-goenka
commented
Aug 20, 2026
| // appRequestBody returns config.App with the deploy-only fields cleared. source_code_path | ||
| // and git_source became part of apps.App in SDK v0.175, but DABs applies them through the | ||
| // Deploy API (see manageLifecycle), so they must not ride along in create/update bodies. | ||
| func appRequestBody(config *AppState) apps.App { |
Contributor
Author
There was a problem hiding this comment.
We can fix this as a followup. For now i want to keep this PR a no-op.
denik
approved these changes
Aug 20, 2026
denik
left a comment
denik
left a comment
Contributor
There was a problem hiding this comment.
@andrewnester could you also review apps part?
|
|
||
| // appRequestBody returns config.App with the deploy-only fields cleared. source_code_path | ||
| // and git_source became part of apps.App in SDK v0.175, but DABs applies them through the | ||
| // Deploy API (see manageLifecycle), so they must not ride along in create/update bodies. |
Contributor
There was a problem hiding this comment.
does Deploy API also supports these or did they remove it there?
is the plan to use create API for these fields in the future?
| app := config.App | ||
| app.SourceCodePath = "" | ||
| app.GitSource = nil | ||
| return app |
Contributor
There was a problem hiding this comment.
this makes a copy, right? can you explicitly mention it here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This SDK bump also inlined GitSource and SourceCodePath into the apps spec so the DABs override is removed in this PR.
DABs still does not fully manage the lifecycle for these fields. The change is purely structural.