Add Docker output format to auth token - #6194
Draft
yolocs wants to merge 1 commit into
Draft
Conversation
yolocs
force-pushed
the
chen-shou_data/stack/dar-configure-docker
branch
2 times, most recently
from
August 17, 2026 19:47
1d40c84 to
8a31a21
Compare
yolocs
commented
Aug 17, 2026
yolocs
force-pushed
the
chen-shou_data/stack/dar-configure-docker
branch
2 times, most recently
from
August 18, 2026 04:36
d8b031a to
3131910
Compare
Contributor
There was a problem hiding this comment.
Thanks @yolocs!
It is big PR with a lot of implicit decisions and behaviors. It would help if we could get more documentation about the intended behavior and usage. Could you maybe rewrite your PR description as if it were documentation intended for the user?
For example, the PR adds a new token format but this is documented nowhere currently. The only way to understand the intended usage is to reverse-guess it from the code.
Left a first round of quick feedback.
yolocs
force-pushed
the
chen-shou_data/stack/dar-configure-docker
branch
from
August 20, 2026 17:54
3d415da to
097fb03
Compare
This was referenced Aug 20, 2026
yolocs
force-pushed
the
chen-shou_data/stack/dar-configure-docker
branch
from
August 20, 2026 19:40
097fb03 to
cd0907f
Compare
yolocs
force-pushed
the
chen-shou_data/stack/dar-configure-docker
branch
from
August 20, 2026 22:38
cd0907f to
3ad7d11
Compare
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR (generated by git ns)
Use this link to review incremental changes.
Changes
Adds the hidden
databricks auth token --format=dockeroutput mode used by the Databricks Docker credential helper.The command accepts no positional argument and rejects
--profile,--host,--account-id, and--workspace-id. It reads a Docker server address from stdin, normalizes and validates a registry host of the form<workspace-id>.container.<region>.<databricks-dns-zone>, and finds the matching workspace-scoped U2M profile. Profile selection uses bothworkspace_idand the workspace DNS zone so identical workspace IDs in different Databricks environments remain distinct.On success, stdout contains Docker's
getresponse:{"Username":"oauthtoken","Secret":"<valid workspace OAuth token>"}The OAuth token is returned unchanged. This mode does not implement credential-helper operation dispatch,
store, orerase; the setup PR adds a shim that invokes it only forget.Why
Docker provides a credential helper with only the registry address, while Databricks OAuth tokens are short-lived and profile-specific. Resolving the registry address back to a workspace profile lets the CLI load and refresh tokens through the existing
auth tokenpath for each Docker request without persisting a registry credential.Tests
go test ./libs/dockercredentials ./cmd/auth -count=1This PR was written by Codex.