internal: Refactor immutable folder upload as an internal resource in direct engine - #6084
internal: Refactor immutable folder upload as an internal resource in direct engine#6084andrewnester wants to merge 35 commits into
Conversation
Approval status: pending
|
Integration test reportCommit: 92ec65c
Top 6 slowest tests (at least 2 minutes):
|
| "deployments": [ | ||
| { | ||
| "command_path": "${workspace.snapshot_path}/files/src/main.py", | ||
| "command_path": "${internal.snapshot.full_path}/files/src/main.py", |
There was a problem hiding this comment.
Instead of custom path, can we keep using ${workspace.file_path}, just make it an alias internally to internal resource's snapshot path.
That way:
- users know what this means
- users can use the variable themselves and it'll work both in regular and immutable case.
There was a problem hiding this comment.
${workspace.file_path} is ${internal.snapshot.full_path}/files and because we resolve the variables ${workspace.file_path} resolved to this pass. I'd prefer not to change the way variable reslution works and introduce some custom aliases
| @@ -35,12 +36,15 @@ type ACLEntry struct { | |||
| // the same workspace location. | |||
| // This interface exists so the implementation can later be replaced with a Go SDK call. | |||
There was a problem hiding this comment.
This does not explain why we need the interface - do we plan on supporting multiple implementation at the same time?
There was a problem hiding this comment.
Strictly speaking we don't need it for SDK replacement later but we need this now in unit tests to replace the uploader with mock one
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/recreate-gone-genie-space-[UNIQUE_NAME]/default | ||
|
|
||
| Destroy: 1 deleted | ||
| Destroy: 0 deleted |
There was a problem hiding this comment.
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
|
|
||
| Destroy: 1 deleted | ||
| Destroy: 0 deleted |
There was a problem hiding this comment.
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle/default | ||
|
|
||
| Destroy: 1 deleted | ||
| Destroy: 0 deleted |
There was a problem hiding this comment.
4 participants
Changes
Refactor immutable folder upload as an internal resource in direct engine
Why
This enables us:
${internal.snapshot.full_path}and it's automatically resolved during deployTests
Existing tests pass