Skip to content

feat(dash): dedicated PlatformNodeId newtype for platform_node_id fields#885

Merged
QuantumExplorer merged 4 commits into
devfrom
claude/awesome-moser-a4d663
Jul 14, 2026
Merged

feat(dash): dedicated PlatformNodeId newtype for platform_node_id fields#885
QuantumExplorer merged 4 commits into
devfrom
claude/awesome-moser-a4d663

test(dash): cover PlatformNodeId hex/serde paths and zero-fill encoding

7fc2321
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 14, 2026 in 1s

74.36% (+0.05%) compared to a959459

View this Pull Request on Codecov

74.36% (+0.05%) compared to a959459

Details

Codecov Report

❌ Patch coverage is 94.73684% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.36%. Comparing base (a959459) to head (7fc2321).

Files with missing lines Patch % Lines
dash/src/platform_node_id.rs 93.44% 4 Missing ⚠️
...ction/special_transaction/provider_registration.rs 97.61% 1 Missing ⚠️
...ion/special_transaction/provider_update_service.rs 96.15% 1 Missing ⚠️
...wallet/src/transaction_checking/account_checker.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #885      +/-   ##
==========================================
+ Coverage   74.30%   74.36%   +0.05%     
==========================================
  Files         326      327       +1     
  Lines       74636    74747     +111     
==========================================
+ Hits        55462    55586     +124     
+ Misses      19174    19161      -13     
Files with missing lines Coverage Δ
dash/src/sml/masternode_list_entry/mod.rs 62.31% <ø> (ø)
key-wallet-ffi/src/special_payload.rs 92.05% <100.00%> (-0.06%) ⬇️
key-wallet/src/derivation_slip10.rs 51.41% <100.00%> (-0.35%) ⬇️
...ction/special_transaction/provider_registration.rs 65.65% <97.61%> (+2.89%) ⬆️
...ion/special_transaction/provider_update_service.rs 82.69% <96.15%> (+0.87%) ⬆️
...wallet/src/transaction_checking/account_checker.rs 53.98% <50.00%> (ø)
dash/src/platform_node_id.rs 93.44% <93.44%> (ø)

... and 9 files with indirect coverage changes