Skip to content

chore: update rust-dashcore to 1ee1c94#4094

Merged
QuantumExplorer merged 1 commit into
v4.1-devfrom
fix/update-rust-dashcore-1ee1c94
Jul 11, 2026
Merged

chore: update rust-dashcore to 1ee1c94#4094
QuantumExplorer merged 1 commit into
v4.1-devfrom
fix/update-rust-dashcore-1ee1c94

Conversation

@QuantumExplorer

@QuantumExplorer QuantumExplorer commented Jul 11, 2026

Copy link
Copy Markdown
Member

Issue being fixed or feature implemented

Keeps platform on the latest rust-dashcore dev HEAD. The pinned rev was 1860089; this bumps to 1ee1c94, picking up four upstream fixes:

  • fix(dash-spv): derive storage lockfile path from full directory name (#862)
  • fix(key-wallet): zeroize ExtendedBLSPrivKey and ExtendedEd25519PrivKey on drop (#859)
  • fix(spv): match masternode owner/voting key hashes in compact filters (#863)
  • fix(spv): match masternode collateral outpoints in compact filters (#864)

What was done?

  • Bumped the rev for all eight rust-dashcore git deps in the root Cargo.toml (dashcore, dash-network-seeds, dash-spv, key-wallet, key-wallet-ffi, key-wallet-manager, dash-network, dashcore-rpc) and refreshed Cargo.lock.
  • fix(scripts): update configure_test_network for hpmn #863 added a new required method monitored_filter_elements to WalletInfoInterface. PlatformWalletInfo implements that trait by delegating to its inner ManagedWalletInfo, so the new method is delegated the same way as the existing monitored_* accessors.

How Has This Been Tested?

cargo check --workspace passes cleanly (exit 0). cargo fmt --all applied.

Breaking Changes

None. The upstream trait addition is handled internally; no platform-facing API changes.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Improved platform wallet monitoring by ensuring monitored filter elements are correctly exposed and used.
    • Updated wallet and network components for improved compatibility and consistency across the platform.
  • Refactor

    • Unified wallet-related components with the latest supporting platform updates.

Bump the pinned rust-dashcore rev from 1860089 to 1ee1c94 (dev HEAD),
picking up four upstream fixes:

- fix(dash-spv): derive storage lockfile path from full directory name (#862)
- fix(key-wallet): zeroize ExtendedBLSPrivKey and ExtendedEd25519PrivKey on drop (#859)
- fix(spv): match masternode owner/voting key hashes in compact filters (#863)
- fix(spv): match masternode collateral outpoints in compact filters (#864)

#863 added a new `monitored_filter_elements` method to
`WalletInfoInterface`; delegate it to the inner `ManagedWalletInfo`
like the other monitored-* accessors.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.1.0 milestone Jul 11, 2026
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87238033-7ec9-4bf1-b003-3bc5f7681dfe

📥 Commits

Reviewing files that changed from the base of the PR and between f7d7c8d and c4ac8a0.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • packages/rs-platform-wallet/src/wallet/platform_wallet_traits.rs

📝 Walkthrough

Walkthrough

The workspace updates Rust Dashcore-related dependency revisions and adds monitored_filter_elements delegation to PlatformWalletInfo’s WalletInfoInterface implementation.

Changes

Rust Dashcore update

Layer / File(s) Summary
Update Rust Dashcore revision
Cargo.toml
Dashcore-related workspace git dependencies now use revision 1ee1c94840f14c63fa34e9d19f6eaaa1d29847c3.
Delegate monitored filter elements
packages/rs-platform-wallet/src/wallet/platform_wallet_traits.rs
PlatformWalletInfo delegates monitored_filter_elements to its inner core_wallet.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: lklimek, shumkov

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: updating rust-dashcore to the new commit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-rust-dashcore-1ee1c94

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thepastaclaw

thepastaclaw commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

✅ Review complete (commit c4ac8a0)

@QuantumExplorer QuantumExplorer merged commit 0a32757 into v4.1-dev Jul 11, 2026
23 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/update-rust-dashcore-1ee1c94 branch July 11, 2026 15:47

@thepastaclaw thepastaclaw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Clean, well-scoped dependency bump of rust-dashcore from 1860089 to 1ee1c94. Both reviewers' claims verified from source: the four cited upstream commits (#862, #859, #863, #864) exist exactly in that git range, the Cargo.toml/Cargo.lock updates are consistent across all 8 rust-dashcore workspace deps, and the new monitored_filter_elements delegation in PlatformWalletInfo exactly mirrors the sibling monitored_addresses/monitored_script_pubkeys delegations, is a required (non-default) WalletInfoInterface method, and wires end-to-end through WalletManager::monitored_filter_elements_for into dash-spv's compact-filter matching. cargo check -p platform-wallet passes cleanly at head.

Source (experiment sonnet-primary-opus-quarter-sample-20260710, cohort sonnet_primary, bucket 3): reviewers codex/general=gpt-5.6-sol(completed parseable; wrapper exit 5); sonnet5/general=claude-sonnet-5(completed); verifier=verifier-sonnet5-4094-1783784426=claude-sonnet-5; orchestrator=openai/gpt-5.6-sol reasoning=high (orchestration-only, not a reviewer/verifier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants