chore: update rust-dashcore to 1ee1c94#4094
Conversation
Bump the pinned rust-dashcore rev from 1860089 to 1ee1c94 (dev HEAD), picking up four upstream fixes: - fix(dash-spv): derive storage lockfile path from full directory name (#862) - fix(key-wallet): zeroize ExtendedBLSPrivKey and ExtendedEd25519PrivKey on drop (#859) - fix(spv): match masternode owner/voting key hashes in compact filters (#863) - fix(spv): match masternode collateral outpoints in compact filters (#864) #863 added a new `monitored_filter_elements` method to `WalletInfoInterface`; delegate it to the inner `ManagedWalletInfo` like the other monitored-* accessors. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe workspace updates Rust Dashcore-related dependency revisions and adds ChangesRust Dashcore update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Review complete (commit c4ac8a0) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Clean, well-scoped dependency bump of rust-dashcore from 1860089 to 1ee1c94. Both reviewers' claims verified from source: the four cited upstream commits (#862, #859, #863, #864) exist exactly in that git range, the Cargo.toml/Cargo.lock updates are consistent across all 8 rust-dashcore workspace deps, and the new monitored_filter_elements delegation in PlatformWalletInfo exactly mirrors the sibling monitored_addresses/monitored_script_pubkeys delegations, is a required (non-default) WalletInfoInterface method, and wires end-to-end through WalletManager::monitored_filter_elements_for into dash-spv's compact-filter matching. cargo check -p platform-wallet passes cleanly at head.
Source (experiment sonnet-primary-opus-quarter-sample-20260710, cohort sonnet_primary, bucket 3): reviewers codex/general=gpt-5.6-sol(completed parseable; wrapper exit 5); sonnet5/general=claude-sonnet-5(completed); verifier=verifier-sonnet5-4094-1783784426=claude-sonnet-5; orchestrator=openai/gpt-5.6-sol reasoning=high (orchestration-only, not a reviewer/verifier).
Issue being fixed or feature implemented
Keeps platform on the latest
rust-dashcoredevHEAD. The pinned rev was1860089; this bumps to1ee1c94, picking up four upstream fixes:ExtendedBLSPrivKeyandExtendedEd25519PrivKeyon drop (#859)What was done?
revfor all eightrust-dashcoregit deps in the rootCargo.toml(dashcore,dash-network-seeds,dash-spv,key-wallet,key-wallet-ffi,key-wallet-manager,dash-network,dashcore-rpc) and refreshedCargo.lock.monitored_filter_elementstoWalletInfoInterface.PlatformWalletInfoimplements that trait by delegating to its innerManagedWalletInfo, so the new method is delegated the same way as the existingmonitored_*accessors.How Has This Been Tested?
cargo check --workspacepasses cleanly (exit 0).cargo fmt --allapplied.Breaking Changes
None. The upstream trait addition is handled internally; no platform-facing API changes.
Checklist:
For repository code-owners and collaborators only
🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Refactor