Skip to content

fix(platform-wallet): report the exact send_payment fee (inputs − outputs) #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 6 commits into from
Jul 12, 2026
+311 −26
Merged

fix(platform-wallet): report the exact send_payment fee (inputs − outputs) #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9cf60ec
docs(platform-wallet): document the fee tuple element and out_fee_duf…
QuantumExplorer Jul 9, 2026
26669c9
fix(platform-wallet): report the actual fee from send_payment, not th…
QuantumExplorer Jul 9, 2026
035436f
test(platform-wallet): pin send_payment's exact fee incl. the dust-dr…
QuantumExplorer Jul 11, 2026
b618286
style(platform-wallet): rustfmt the new send_payment fee tests
QuantumExplorer Jul 11, 2026
18df0b5
docs(swift-sdk): correct sendDashPayPayment fee comment (not 'straigh…
QuantumExplorer Jul 11, 2026
fae738b
refactor(platform-wallet): take send_payment's fee from the builder (…
QuantumExplorer Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ members = [
]

[workspace.dependencies]
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "d4692bb29c626942ddf51204d50d90206c1a5b0c" }
dashcore = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }
dash-network-seeds = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }
dash-spv = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }
key-wallet = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }
key-wallet-ffi = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }
key-wallet-manager = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }
dash-network = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }
dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore", rev = "234e3c4333f3be6f7a1d01e5af90805ae49783c7" }

tokio-metrics = "0.5"

Expand Down
10 changes: 7 additions & 3 deletions packages/rs-platform-wallet-ffi/src/dashpay.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,8 @@ pub unsafe extern "C" fn platform_wallet_fetch_sent_contact_requests(
/// - `core_signer_handle` must be a valid, non-destroyed
/// `*mut MnemonicResolverHandle`. Ownership is retained by the caller —
/// this function does NOT destroy it.
/// - `out_fee_duffs` may be NULL to ignore the fee; when non-null it must
/// point to valid writable `u64` storage, written only on success.
#[no_mangle]
#[allow(clippy::too_many_arguments)]
pub unsafe extern "C" fn platform_wallet_send_dashpay_payment(
Expand Down Expand Up @@ -594,9 +596,11 @@ pub unsafe extern "C" fn platform_wallet_send_dashpay_payment(
});
let result = unwrap_option_or_return!(option);
let (txid, _entry, fee_duffs) = unwrap_result_or_return!(result);
// Exact network fee of the broadcast transaction (inputs − outputs),
// straight from the builder — nullable so callers that don't care
// can pass NULL.
// Exact network fee of the broadcast transaction — Σ(selected input
// values) − Σ(output values), computed by the transaction builder
// itself since rust-dashcore#872, so a sub-dust change remainder
// folded into the fee is reflected here. Nullable so callers that
// don't care can pass NULL.
if !out_fee_duffs.is_null() {
unsafe { *out_fee_duffs = fee_duffs };
}
Expand Down
Loading
Loading