chore: remove ignored cargo build config#3948
Conversation
|
✅ Review complete (commit 7f206c3) |
|
Warning Review limit reached
More reviews will be available in 48 minutes and 56 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThree crate manifests ( ChangesRelease Profile Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
PR #3948 removes ignored [profile.release] blocks from three non-root workspace member Cargo.toml files (rs-sdk-ffi, wasm-dpp, wasm-sdk). Cargo only honors profiles defined at the workspace root, so these sections were dead config; iOS builds use workspace-level release-ios/dev-ios profiles and wasm builds inject release settings via cargo --config. Both agents and CodeRabbit found no actionable issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.1-dev #3948 +/- ##
==========================================
Coverage 87.17% 87.18%
==========================================
Files 2629 2632 +3
Lines 327221 327563 +342
==========================================
+ Hits 285265 285592 +327
- Misses 41956 41971 +15
🚀 New features to boost your workflow:
|
2034316 to
2168be3
Compare
2168be3 to
7f206c3
Compare
In this PR I remove the profile.release sections in the crates Cargo.toml. They were not being applied bcs they need to be specified at the workspace level. I didn't write a replacement because the workspace already provides optimized profiles for the swift sdk builds
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit