Skip to content

fix(http2): reject requests that exceed SETTINGS_MAX_CONCURRENT_STREAMS - #1965

Open
brianquinlan wants to merge 7 commits into
dart-lang:masterfrom
brianquinlan:max_connection
Open

fix(http2): reject requests that exceed SETTINGS_MAX_CONCURRENT_STREAMS#1965
brianquinlan wants to merge 7 commits into
dart-lang:masterfrom
brianquinlan:max_connection

Conversation

@brianquinlan

@brianquinlan brianquinlan commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator
  1. Return REFUSED_STREAM if the peer requests more peers then were advertised in SETTINGS_MAX_CONCURRENT_STREAMS. This is a requirement according to RFC-7540 5.1.2.
  2. Modify the tests/format/etc. to run with the stable version of Dart - the dev and stable versions of Dart currently disagree on formatting.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@github-actions github-actions Bot added the type-infra A repository infrastructure change or enhancement label Aug 7, 2026
@brianquinlan
brianquinlan requested a review from mosuem August 7, 2026 17:03
Comment thread pkgs/http2/test/server_test.dart Outdated
Co-authored-by: Nate Bosch <nbosch1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:http2 type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants