Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/cronet.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: package:cronet_http CI

Check warning on line 1 in .github/workflows/cronet.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions

cronet.yml:1: overly broad permissions: default permissions used due to no permissions: block

on:
push:
Expand All @@ -21,7 +21,7 @@
PUB_ENVIRONMENT: bot.github

jobs:
generate:

Check warning on line 24 in .github/workflows/cronet.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions

cronet.yml:24: overly broad permissions: default permissions used due to no permissions: block
name: jnigen
runs-on: ubuntu-latest
defaults:
Expand All @@ -39,8 +39,6 @@
- id: install
name: Install dependencies
run: flutter pub get
- name: Build APK
run: cd example && flutter build apk && cd ..
- name: Upgrade
# Set this to `true` if you are using this workflow to regenerate the jni
# bindings.
Expand All @@ -58,7 +56,7 @@
name: JNI Bindings
path: pkgs/cronet_http/lib/src/jni/jni_bindings.dart
retention-days: 1
verify:

Check warning on line 59 in .github/workflows/cronet.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions

cronet.yml:59: overly broad permissions: default permissions used due to no permissions: block
name: Format & Analyze & Test (${{ matrix.cronetHttpNoPlay == 'true' && 'without Google Play' || 'with Google Play'}})
runs-on: ubuntu-cpu16-ram64
timeout-minutes: 30
Expand Down
4 changes: 4 additions & 0 deletions pkgs/cronet_http/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.9.1-wip

* Upgrade `package:jnigen` to 0.17.0.

## 1.9.0

* Add `CronetEngine.startNetLogToFile` and `CronetEngine.stopNetLog`.
Expand Down
4 changes: 4 additions & 0 deletions pkgs/cronet_http/example/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ org.gradle.jvmargs=-Xmx12800M
org.gradle.caching=true
android.useAndroidX=true
android.enableJetifier=true
# This builtInKotlin flag was added automatically by Flutter migrator
android.builtInKotlin=false
# This newDsl flag was added automatically by Flutter migrator
android.newDsl=false
6 changes: 3 additions & 3 deletions pkgs/cronet_http/lib/src/cronet_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ class CronetEngine {
try {
return using((arena) {
final builder = jb.CronetEngine$Builder(
androidApplicationContext..releasedBy(arena))
(androidApplicationContext as jb.Context)..releasedBy(arena))
..releasedBy(arena);

if (storagePath != null) {
Expand Down Expand Up @@ -696,7 +696,7 @@ class CronetClient extends BaseClient {
jUrl,
jb.UrlRequestCallbackProxy(
_urlRequestCallbacks(request, responseCompleter, profile)),
_executor,
_executor as jb.Executor,
)!
..releasedBy(arena)
..setHttpMethod(jMethod);
Expand Down Expand Up @@ -728,7 +728,7 @@ class CronetClient extends BaseClient {
}

builder.setUploadDataProvider(
jb.UploadDataProviders.create$2(data), _executor);
jb.UploadDataProviders.create$2(data), _executor as jb.Executor);
}

// Not releasing `cronetRequest` as it's used in `whenComplete` callback.
Expand Down
Loading
Loading