feat: make terminal appearance themeable - #314
Open
arzafran wants to merge 1 commit into
Open
Conversation
Extends the existing terminal theme managed-config-block pattern (theme name selection) to also cover background opacity, background blur, and custom fonts, each independently controllable from Settings, settings.json, or the CLI. Adds two new bundled themes, Min Light and Min Dark, styled after the Min Theme VS Code extension.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
You can now theme the terminal's look beyond just picking a theme name — opacity, background blur, and custom fonts are each independently controllable from Settings, settings.json, or the CLI. Two new bundled themes are included, Min Light and Min Dark, styled after the popular Min Theme VS Code extension.
Summary
managedRawAppearance()) instead of cascading in values from the user's own raw Ghostty config, andbackground-blurnow has a representable explicit-false state instead of silently reverting to whatever the user's own config has setdocs/terminal-themes.mdandResources/settings.schema.jsonfor the new settingsTest Plan
programaTests/WorkspaceUnitTests.swift, 34/34 passing (verified by implementer)revieweragent — flagged two Critical bugs, both fixed and re-verified before this PR