Refactor player transfers by oznogon · Pull Request #2851 · daid/EmptyEpsilon

oznogon · 2026-04-10T00:14:35Z

Fix [ECS Regression]: transferPlayersToShip does not reset radar focus #2848 by tracking when a radar view should lock onto my_spaceship and updating auto_center_target appropriately.
Fix [Bug] transferPlayers... functions allow transferring to crew positions prohibited on the destination ship #2849 by checking against the allowed_positions mask and transferring players to allowed positions on the destination.
Fix [Bug] transferPlayers... functions retain the old ship's cached password #2850 by clearing the cached password after transferring players to a new ship. It's up to the scenario author/GM to communicate the new ship's password to players if necessary.

GuiRadarView initializes auto_center_target from my_spaceship at construction but never updates it. After transferPlayersToShip() moves a player to a new ship, radar views remained centered on the old ship until the player logs out and back in. Add a track_my_spaceship flag that keeps auto_center_target in sync with my_spaceship each frame when true (default). Calling setAutoCenterTarget() clears the flag, preserving behaviours that temporarily lock onto an arbitrary target, like Spectator.

- If transferring a player in a position prohibited on the destination entity, move the player to an allowed position and log a warning. If the destination has no allowed positions, log an error and reset the destination's allowed positions to any. - If transferring to a ship that lacks a PlayerControl component, add it. - If transferring to a ship that has an AIController component, remove it.

Co-authored-by: Garrett Guillotte <oznogon@users.noreply.github.com>

…ctor-player-transfer

daid · 2026-06-05T12:14:13Z

-    const GuiThemeStyle* ship_waypoint_style;
-    const GuiThemeStyle* ship_waypoint_background_style;
-    const GuiThemeStyle* ship_waypoint_text_style;
+    const GuiThemeStyle* radar_style = theme->getStyle("radar");


I'm surprised that this work, but, I do like that we removed a whole bunch of duplication :)

oznogon added 2 commits April 9, 2026 17:06

oznogon mentioned this pull request Apr 10, 2026

[ECS Regression]: transferPlayersToShip does not reset radar focus #2848

Closed

GinjaNinja32 reviewed Jun 3, 2026

View reviewed changes