fix(core): resume without queued events#739
Merged
Merged
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesResume without queued events
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 060a256 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@stackflow/core
@stackflow/link
@stackflow/plugin-activity-guard
@stackflow/plugin-basic-ui
@stackflow/plugin-blocker
@stackflow/plugin-devtools
@stackflow/plugin-google-analytics-4
@stackflow/plugin-history-sync
@stackflow/plugin-lifecycle
@stackflow/plugin-renderer-basic
@stackflow/plugin-renderer-web
@stackflow/plugin-sentry
@stackflow/plugin-stack-depth-change
@stackflow/plugin-stack-persistence
@stackflow/react-ui-core
@stackflow/react
commit: |
Deploying stackflow-demo with
|
| Latest commit: |
060a256
|
| Status: | ⚡️ Build in progress... |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | 060a256 | Commit Preview URL | Jul 26 2026, 04:38 PM |
ENvironmentSet
marked this pull request as ready for review
July 24, 2026 07:36
ENvironmentSet
enabled auto-merge (squash)
July 24, 2026 07:36
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
core/src/aggregate.spec.ts (1)
4135-4162: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the new
loadingbranch.This test only exercises resumption with no active transitions, so it cannot catch regressions in the new
enter-active/exit-activepath that should restoreglobalTransitionStateto"loading".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/src/aggregate.spec.ts` around lines 4135 - 4162, Add coverage in the aggregate test for the loading branch by constructing events with an active transition before the Paused and Resumed events, such as an enter-active/exit-active sequence. Assert that Resumed restores globalTransitionState to "loading" while retaining the expected pausedEvents and event list behavior; keep the existing idle-state scenario unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@core/src/aggregate.spec.ts`:
- Around line 4135-4162: Add coverage in the aggregate test for the loading
branch by constructing events with an active transition before the Paused and
Resumed events, such as an enter-active/exit-active sequence. Assert that
Resumed restores globalTransitionState to "loading" while retaining the expected
pausedEvents and event list behavior; keep the existing idle-state scenario
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4cd72b25-6a42-4412-8d81-045684dcf8ce
📒 Files selected for processing (4)
.changeset/fep-2636-resume-without-queued-events.mdcore/src/activity-utils/makeStackReducer.tscore/src/aggregate.spec.tscore/src/makeCoreStore.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pause().globalTransitionStatetoidleorloadingfrom the current Activity transitions when resuming.onResumedand subsequent navigation.Linear: FEP-2636