Ship's prompts travel with its package#90
Open
czpython wants to merge 1 commit into
Open
Conversation
The prompts sat in a platform-level backend/templates/ that only ship used, kept in the wheel by a force-include. They move under druks/contrib/ship/templates/prompts/, where the resolver already looks: it globs every installed extension package for its own templates/prompts root, so an extension shipped separately carries its prompts with it. Prompt names are unchanged, and so is the .druks/ship/prompts/ override path. That was the last thing in backend/templates/, so the directory, the force-include, and the loader entry pointing at it go with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #89.
The prompts sat in a platform-level
backend/templates/that only ship used, kept in the wheel by aforce-include. They move tobackend/druks/contrib/ship/templates/prompts/, where the resolver already looks: it globs every installed extension package for its owntemplates/promptsroot, so an extension shipped separately carries its prompts with it.Prompt names are unchanged (
ship/build/*.md), and so is the.druks/ship/prompts/build/*.mdoverride path.That was the last thing in
backend/templates/, so the directory goes, and with it theforce-include, the sdist entry, and thePROMPTS_DIRloader entry that pointed at it — the wheel now carries the prompts because they live inside the package.Verified:
uv build --wheelships all 14.mdfiles underdruks/contrib/ship/templates/prompts/; ruff check, ruff format --check, pytest --collect-only (959 collected), frontend vitest (51 passed).