vmm, vm-migration: add MigrationStateOngoingPhase::Started#178
Merged
phip1611 merged 1 commit intoJul 2, 2026
Merged
Conversation
phip1611
force-pushed
the
improve-send-migration-observability
branch
2 times, most recently
from
7d8796b to
ae2e4f2
Compare
phip1611
requested review from
arctic-alpaca,
olivereanderson and
scholzp
and removed request for
olivereanderson
There was a problem hiding this comment.
The commit referenced in the commit message for vmm, vm-migration: streamline error chain message with upstream should be cloud-hypervisor@2527020, since that is the one in main.
No action required, but just want to point out that I would have preferred to have two PRs, since the changes don't seem related.
phip1611
force-pushed
the
improve-send-migration-observability
branch
from
ae2e4f2 to
be02ad7
Compare
Member
Author
thanks - I agree. I already did a split-out nevertheless to keep changes clean |
This will help us in libvirt/ch to distinguish short send/receive races from a real migration startup failure. By being able to check if the migration has been successfully started (rather than just the migration worker thread), we can improve the reliability of the start_migration() logic in libvirt/ch. On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
phip1611
force-pushed
the
improve-send-migration-observability
branch
from
be02ad7 to
179eb5d
Compare
phip1611
commented
Jul 2, 2026
| // Signal that the migration connection has been established. Management | ||
| // software can use this to distinguish short send/receive races from a | ||
| // real migration startup failure. | ||
| { |
Member
Author
There was a problem hiding this comment.
btw @arctic-alpaca I know that this is rather poor design that we have to follow here - it comes from our "pragmatic" impl in the fork. Will (and must) be done much nicer when we upstream it
olivereanderson
approved these changes
Jul 2, 2026
cyberus-renovate
pushed a commit
to cyberus-technology/libvirt
that referenced
this pull request
Jul 2, 2026
cloud-hypervisor: 2026-06-29T16:20:34+02:00 -> 2026-07-02T13:20:05+02:00 This includes the new migration phase marker [0] and [1]. [0] cyberus-technology/cloud-hypervisor#178 [1] cyberus-technology/cloud-hypervisor#179 This commit was generated via: nix run github:phip1611/nixos-configs#flake-update-and-commit On-behalf-of: SAP philipp.schuster@sap.com Signed-off-by: Philipp Schuster <philipp.schuster@cyberus-technology.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My proposed solution for https://github.com/cobaltcore-dev/cobaltcore/issues/598. Needs libvirt patches additionally (https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/251/).
This will help us in libvirt/ch to distinguish short send/receive races
from a real migration startup failure. By being able to check if the
migration has been successfully started (rather than just the migration
worker thread), we can improve the reliablity of the start_migration()
logic in libvirt/ch.
libvirt CI pipeline: https://gitlab.cyberus-technology.de/cyberus/cloud/libvirt/-/merge_requests/251/pipelines