kt: Introduce kt checkout/vm for rlc kernels#78
Open
roxanan1996 wants to merge 1 commit into
Open
Conversation
Similar to current implementation for the lts kernels, except for 2 changes: 1. source tree branch changes for rlc when a new version is released, hence we cannot lock a specific version in kernels.yaml file. Instead a pattern is used. And when kt checkout is used, the latest branch that matches the pattern is found and used. 2. if a new minor rocky version is released, qcow images are usually published later. Hence the url for a specific rocky linux won't work. As a temporary solution, the latest qcow image is used for a major version. Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
roxanan1996
force-pushed
the
{rnicolescu}_kt_add_rlc_checkout_and_vm
branch
from
ea54409 to
070ff15
Compare
There was a problem hiding this comment.
Pull request overview
Introduces support for RLC kernel workspaces by adding a kernel “type” concept, selecting the newest matching source-tree branch at checkout time, and switching VM image download base URLs to use Rocky’s public mirror for RLC.
Changes:
- Add
kernel_typemetadata to kernel definitions and introduce aKernelTypeenum. - For RLC kernels, resolve
src_tree_branchpatterns (withX.Yplaceholders) to the newest matching remote branch during workspace load. - Use a different Rocky Linux base URL for RLC VM qcow2 downloads.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| kt/ktlib/vm.py | Selects VM image base URL depending on kernel type. |
| kt/ktlib/util.py | Adds an RLC-specific Rocky download base URL constant. |
| kt/ktlib/kernels.py | Introduces KernelType and adds kernel_type to KernelInfo. |
| kt/ktlib/kernel_workspace.py | Adds RLC-aware branch resolution and worktree update behavior. |
| kt/data/kernels.yaml | Adds kernel_type fields and new RLC kernel entries with branch patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1
to
4
| import logging | ||
| from dataclasses import dataclass | ||
| from enum import StrEnum, auto | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to current implementation for the lts kernels, except for 2 changes: