Skip to content

hooks: Fail open on intake errors in Rust CLI and agent-trace plugin #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidabram merged 2 commits into from
Jul 1, 2026
Merged

hooks: Fail open on intake errors in Rust CLI and agent-trace plugin #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb82367
hooks: Fail open on intake errors in Rust CLI and agent-trace plugin
stefanskoricdev Jun 30, 2026
7142524
hooks: Show install guidance when sce is missing
stefanskoricdev Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .claude/hooks/run-sce-or-show-install-guidance.sh
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions .claude/settings.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

57 changes: 27 additions & 30 deletions .opencode/plugins/sce-agent-trace.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .opencode/plugins/sce-bash-policy.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions cli/assets/hooks/post-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ set -eu

remote_url="$(git remote get-url origin 2>/dev/null || true)"

if ! command -v sce >/dev/null 2>&1; then
echo "sce CLI not found. Install it from https://sce.crocoder.dev/docs/getting-started#install-cli" >&2
exit 0
fi

if [ -n "$remote_url" ]; then
exec sce hooks post-commit --vcs git --remote-url "$remote_url" "$@"
fi
Expand Down
66 changes: 40 additions & 26 deletions cli/src/services/hooks/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,9 @@ fn run_hooks_subcommand_in_repo(
HookSubcommand::PostRewrite { rewrite_method } => {
run_post_rewrite_subcommand_with_trace(repository_root, subcommand, rewrite_method)
}
HookSubcommand::DiffTrace => run_diff_trace_subcommand(repository_root, logger),
HookSubcommand::DiffTrace => Ok(run_diff_trace_subcommand(repository_root, logger)),
HookSubcommand::ConversationTrace => {
run_conversation_trace_subcommand(repository_root, logger)
Ok(run_conversation_trace_subcommand(repository_root, logger))
}
HookSubcommand::SessionModel => run_session_model_subcommand(repository_root, logger),
}
Expand All @@ -208,20 +208,16 @@ fn run_hooks_subcommand_in_repo(
fn run_conversation_trace_subcommand(
repository_root: &Path,
logger: Option<&dyn Logger>,
) -> Result<String> {
let stdin_payload = read_hook_stdin()?;
let result =
run_conversation_trace_subcommand_from_payload(repository_root, &stdin_payload, logger);
if let Err(ref error) = result {
if let Some(log) = logger {
log.error(
"sce.hooks.conversation_trace.error",
&error.to_string(),
&[],
);
}
) -> String {
let stdin_payload = match read_hook_stdin() {
Ok(payload) => payload,
Err(error) => return log_conversation_trace_fail_open(&error, logger),
};

match run_conversation_trace_subcommand_from_payload(repository_root, &stdin_payload, logger) {
Ok(output) => output,
Err(error) => log_conversation_trace_fail_open(&error, logger),
}
result
}

fn run_conversation_trace_subcommand_from_payload(
Expand All @@ -233,6 +229,18 @@ fn run_conversation_trace_subcommand_from_payload(
persist_conversation_trace_payload_to_agent_trace_db(repository_root, payload, logger)
}

fn log_conversation_trace_fail_open(error: &anyhow::Error, logger: Option<&dyn Logger>) -> String {
if let Some(log) = logger {
log.error(
"sce.hooks.conversation_trace.error",
&error.to_string(),
&[],
);
}

String::from("conversation-trace hook intake failed open; error logged.")
}

fn persist_conversation_trace_payload_to_agent_trace_db(
repository_root: &Path,
payload: ConversationTracePayload,
Expand Down Expand Up @@ -666,18 +674,16 @@ fn conversation_trace_validation_error(detail: &str) -> String {
format!("Invalid conversation-trace payload from STDIN: {detail}.")
}

fn run_diff_trace_subcommand(
repository_root: &Path,
logger: Option<&dyn Logger>,
) -> Result<String> {
let stdin_payload = read_hook_stdin()?;
let result = run_diff_trace_subcommand_from_payload(repository_root, &stdin_payload, logger);
if let Err(ref error) = result {
if let Some(log) = logger {
log.error("sce.hooks.diff_trace.error", &error.to_string(), &[]);
}
fn run_diff_trace_subcommand(repository_root: &Path, logger: Option<&dyn Logger>) -> String {
let stdin_payload = match read_hook_stdin() {
Ok(payload) => payload,
Err(error) => return log_diff_trace_fail_open(&error, logger),
};

match run_diff_trace_subcommand_from_payload(repository_root, &stdin_payload, logger) {
Ok(output) => output,
Err(error) => log_diff_trace_fail_open(&error, logger),
}
result
}

fn run_diff_trace_subcommand_from_payload(
Expand Down Expand Up @@ -711,6 +717,14 @@ fn run_diff_trace_subcommand_from_payload(
)
}

fn log_diff_trace_fail_open(error: &anyhow::Error, logger: Option<&dyn Logger>) -> String {
if let Some(log) = logger {
log.error("sce.hooks.diff_trace.error", &error.to_string(), &[]);
}

String::from("diff-trace hook intake failed open; error logged.")
}

fn run_diff_trace_subcommand_from_payload_with<R>(
repository_root: &Path,
payload: &DiffTracePayload,
Expand Down
9 changes: 9 additions & 0 deletions config/.claude/hooks/run-sce-or-show-install-guidance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/usr/bin/env bash
set -euo pipefail

if ! command -v sce >/dev/null 2>&1; then
echo "sce CLI not found. Install it from https://sce.crocoder.dev/docs/getting-started#install-cli" >&2
exit 0
fi

exec "$@"
12 changes: 6 additions & 6 deletions config/.claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"hooks": [
{
"type": "command",
"command": "sce hooks session-model"
"command": "bash .claude/hooks/run-sce-or-show-install-guidance.sh sce hooks session-model"
}
]
}
Expand All @@ -17,7 +17,7 @@
"hooks": [
{
"type": "command",
"command": "sce policy bash"
"command": "bash .claude/hooks/run-sce-or-show-install-guidance.sh sce policy bash"
}
]
}
Expand All @@ -28,15 +28,15 @@
"hooks": [
{
"type": "command",
"command": "sce hooks diff-trace"
"command": "bash .claude/hooks/run-sce-or-show-install-guidance.sh sce hooks diff-trace"
}
]
},
{
"hooks": [
{
"type": "command",
"command": "sce hooks conversation-trace"
"command": "bash .claude/hooks/run-sce-or-show-install-guidance.sh sce hooks conversation-trace"
}
]
}
Expand All @@ -46,7 +46,7 @@
"hooks": [
{
"type": "command",
"command": "sce hooks conversation-trace"
"command": "bash .claude/hooks/run-sce-or-show-install-guidance.sh sce hooks conversation-trace"
}
]
}
Expand All @@ -56,7 +56,7 @@
"hooks": [
{
"type": "command",
"command": "sce hooks conversation-trace"
"command": "bash .claude/hooks/run-sce-or-show-install-guidance.sh sce hooks conversation-trace"
}
]
}
Expand Down
Loading
Loading