Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
# Changelog

## Unreleased
- Fixed `ctk cfr jobstats` bugs related anonymization, views, ui, report
and collect arguments.
- Breaking change: `ctk info jobs` reported the 99th percentile of the query duration as
`p90`. The field of the `top100_count` element is called `p99` now.
- Documentation: Explained `ctk info jobs` and `ctk cfr jobstats`, and how they differ
- Breaking change: Dropped support for Python 3.8 and 3.9, which have reached
end-of-life. The minimum supported Python version is now 3.10.
- Fixed a failing SQL statement during `ctk info cluster`
Expand Down
6 changes: 3 additions & 3 deletions cratedb_toolkit/cfr/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def job_statistics(ctx: click.Context):
@click.option(
"--anonymize",
type=str,
is_flag=True,
is_flag=False,
flag_value="decoder_dictionary.json", # Use this value when flag is used without value
default=None, # No anonymization by default
help="Path to the decoder dictionary file for anonymizing SQL statements",
Expand Down Expand Up @@ -203,7 +203,7 @@ def job_statistics_report(ctx: click.Context):
import cratedb_toolkit.cfr.marimo

address = DatabaseAddress.from_string(ctx.meta["cluster_url"])
probe_database_schema(address, schema_name="stats")
probe_database_schema(address, schema_name=address.schema or "stats")
os.environ["CRATEDB_CLUSTER_URL"] = address.dburi
cratedb_toolkit.cfr.marimo.app.run()

Expand All @@ -221,7 +221,7 @@ def job_statistics_ui(ctx: click.Context):
import cratedb_toolkit.cfr.marimo

address = DatabaseAddress.from_string(ctx.meta["cluster_url"])
probe_database_schema(address, schema_name="stats")
probe_database_schema(address, schema_name=address.schema or "stats")
os.environ["CRATEDB_CLUSTER_URL"] = address.dburi
server = marimo.create_asgi_app()
server = server.with_app(path="/", root=cratedb_toolkit.cfr.marimo.__file__)
Expand Down
Loading