Skip to content

Publish min build with GitHub action in orphan branch min - #121

Draft
WolfgangDrescher wants to merge 3 commits into
craigsapp:masterfrom
WolfgangDrescher:min-build
Draft

Publish min build with GitHub action in orphan branch min#121
WolfgangDrescher wants to merge 3 commits into
craigsapp:masterfrom
WolfgangDrescher:min-build

Conversation

@WolfgangDrescher

Copy link
Copy Markdown
Collaborator

Based on my ideas in #117 here is a draft PR for how I would create the GitHub Action to automatically build the min files for the current master branch.

Some thoughts to consider:

  • What git config user.name and git config user.email would you like to use?
  • We should update min/README.txt to a Markdown file.
  • Has support for midifile.h/midifile.cpp been dropped at some point? If so, we should remove it from min/README.txt.
  • We need to stop automatically creating the min/humlib.* files when running the various make * commands. Could you help me identify which make commands should be updated, as I am not fully familiar with all the available make commands?

Feel free to close this PR if it does not align with your vision for the future direction of humlib.

@craigsapp

Copy link
Copy Markdown
Owner

That sound great!

What git config user.name and git config user.email would you like to use?

Probably:

git config --global user.name "Craig Stuart Sapp"
git config --global user.email "craigsapp@gmail.com"

Has support for midifile.h/midifile.cpp been dropped at some point? If so, we should remove it from min/README.txt.

I will need it in the future (if not already). I need to update hum2mid to use the midifile library. Probably copy it into humlib, but do not include in min/humlib.* (since it is already included in verovio). Also I need to update pugixml files (to match update from verovio as well)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants