Publish min build with GitHub action in orphan branch min - #121
Draft
WolfgangDrescher wants to merge 3 commits into
Draft
Publish min build with GitHub action in orphan branch min#121WolfgangDrescher wants to merge 3 commits into
min#121WolfgangDrescher wants to merge 3 commits into
Conversation
Owner
|
That sound great!
Probably: git config --global user.name "Craig Stuart Sapp"
git config --global user.email "craigsapp@gmail.com"
I will need it in the future (if not already). I need to update hum2mid to use the midifile library. Probably copy it into humlib, but do not include in min/humlib.* (since it is already included in verovio). Also I need to update pugixml files (to match update from verovio as well)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on my ideas in #117 here is a draft PR for how I would create the GitHub Action to automatically build the min files for the current master branch.
Some thoughts to consider:
git config user.nameandgit config user.emailwould you like to use?min/README.txtto a Markdown file.midifile.h/midifile.cppbeen dropped at some point? If so, we should remove it frommin/README.txt.min/humlib.*files when running the variousmake *commands. Could you help me identify which make commands should be updated, as I am not fully familiar with all the available make commands?Feel free to close this PR if it does not align with your vision for the future direction of humlib.