Add reusable PR Slack notification workflow - #105
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an org-level reusable GitHub Actions workflow to send a Slack notification when the craft-cloud team is requested as a pull request reviewer.
Changes:
- Introduces a
workflow_call-based workflow that posts a structured Slack message (viajq+curl) for Craft Cloud review requests.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
timkelty
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
.github/workflows/pr-slack-notification.yml:25
- This reusable workflow assumes it’s called from a PR-triggered workflow (it reads
github.event.pull_request.*). If a caller invokes it from a non-PR event (e.g., workflow_dispatch/schedule), these expressions resolve empty and the workflow will still post a misleading Slack message with missing link/title/author. Consider validating the required PR fields at runtime (and fail fast with a clear error) to make the reusable interface safer.
run: |
set -o pipefail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a reusable workflow that posts pull request details to a configured Slack webhook. Calling workflows decide which pull request events and conditions should trigger a notification.
Related issues
None.