Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in 2021)) by danmar · Pull Request #8654 · cppcheck-opensource/cppcheck

danmar · 2026-06-16T11:46:36Z

No description provided.

firewave

This feels like a compiler bug to me.

We should make noexcept optional as a hack for this compiler in question instead of rolling back perfectly valid code.

firewave · 2026-06-16T12:32:48Z

See also https://trac.cppcheck.net/ticket/14851 to make sure such problems are not just platform-specific.

danmar · 2026-06-16T12:34:44Z

@firewave thanks for your review.. I also feel these errors are pretty weird. do you have some more specifiec suggestion how we hack it..

how about :

#ifdef GCC_BUG_HACK_NOEXCEPT
#define  NOEXCEPT
#else 
#define  NOEXCEPT  noexcept
#endif

And then I use NOEXCEPT in the constructor and assignment operator?

So when compiling on oraclelinux I will have to provide -DGCC_BUG_HACK_NOEXCEPT

… 2021))

danmar · 2026-06-16T13:16:22Z

See also https://trac.cppcheck.net/ticket/14851 to make sure such problems are not just platform-specific.

testing more platforms/compilers sounds good to me. we can easily break stuff..

firewave · 2026-06-16T13:59:15Z

@firewave thanks for your review.. I also feel these errors are pretty weird. do you have some more specifiec suggestion how we hack it..

how about :
#ifdef GCC_BUG_HACK_NOEXCEPT
#define  NOEXCEPT
#else 
#define  NOEXCEPT  noexcept
#endif
And then I use NOEXCEPT in the constructor and assignment operator?

So when compiling on oraclelinux I will have to provide -DGCC_BUG_HACK_NOEXCEPT

Something along those lines. Using gcc -dM -E - < /dev/null you can check the compiler for some platform-specific defines.

danmar · 2026-06-16T15:11:55Z

Something along those lines. Using gcc -dM -E - < /dev/null you can check the compiler for some platform-specific defines.

I was not sure if it was a g++ 8.5.0 generic bug. Or what versions are affected.

but I now see that we can reproduce with godbolt also...

https://godbolt.org/z/YjGPdxsbK

firewave · 2026-06-16T15:26:26Z

I was not sure if it was a g++ 8.5.0 generic bug. Or what versions are affected.

but I now see that we can reproduce with godbolt also...

https://godbolt.org/z/YjGPdxsbK

That code appears to be invalid as it doesn't compile at all regardless of version or compiler.

danmar · 2026-06-16T15:44:28Z

That code appears to be invalid as it doesn't compile at all regardless of version or compiler.

yes .. and when I fix that then 8.5 doesn't complain anymore. :-(
I don't see how to reproduce on godbolt with a short code example unfortunately.
but I have also been able to reproduce the same issue on ubuntu:20.04 which uses g++ 9.4.0 compiler.

danmar · 2026-06-17T08:05:57Z

@firewave ping could you please look? this blocks a cppcheck premium release as I can't build release binaries.

firewave · 2026-06-17T08:32:24Z

I have a system which has lots of old GCC versions installed and I wanted to give it a spin with it first but I won't until later today.

Copilot

Pull request overview

This PR addresses a GCC ≤9 (not Clang) compilation failure reported on Oracle Linux 8 by relaxing the noexcept specification for Settings move operations under affected compiler versions, and extends CI coverage to include an oraclelinux:8 container build. It also includes a small header formatting cleanup in lib/checks.h.

Changes:

Add a GCC-version-guarded workaround to omit noexcept on Settings move ctor/assignment for GCC ≤9.
Add oraclelinux:8 to the Docker-based Unix-ish CI matrix and install required build dependencies.
Minor namespace closing brace cleanup in lib/checks.h.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
`lib/settings.h`	Introduces the GCC workaround macro and applies it to `Settings` move operations.
`lib/settings.cpp`	Applies the workaround macro to the defaulted move operations’ definitions.
`lib/checks.h`	Removes an unnecessary trailing semicolon after a namespace block.
`.github/workflows/CI-unixish-docker.yml`	Adds Oracle Linux 8 to CI and installs dependencies for that container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

danmar · 2026-06-17T08:36:41Z

I have a system which has lots of old GCC versions installed and I wanted to give it a spin with it first but I won't until later today.

alright I will wait until later today.


-    Settings(Settings&&) noexcept;
-    Settings& operator=(Settings&&) noexcept;
+    Settings(Settings&&) CPPCHECK_NOEXCEPT;


-    Settings(Settings&&) noexcept;
-    Settings& operator=(Settings&&) noexcept;
+    Settings(Settings&&) CPPCHECK_NOEXCEPT;
+    Settings& operator=(Settings&&) CPPCHECK_NOEXCEPT;


-    Settings(Settings&&) noexcept;
-    Settings& operator=(Settings&&) noexcept;
+    Settings(Settings&&) CPPCHECK_NOEXCEPT;
+    Settings& operator=(Settings&&) CPPCHECK_NOEXCEPT;


firewave · 2026-06-17T11:07:01Z

I have a system which has lots of old GCC versions installed and I wanted to give it a spin with it first but I won't until later today.

alright I will wait until later today.

Ugh. Won't happen that soon. Something in my main machine broke as it starts but I am only getting a black screen.

firewave · 2026-06-17T18:22:59Z

The graphics card was simply loose...

I was able to reproduce the issue with GCC 7 to 9 (no earlier version handy) and it is working with GCC 10 and up.

firewave · 2026-06-18T11:56:35Z

          - image: "alpine:3.23"
            with_gui: false  # it appears FindQt6.cmake is not provided by any package
            full_build: false  # FIXME: test-signalhandler.cpp fails to build since feenableexcept() is missing
+          - image: "oraclelinux:8"


Please use oraclelinux:8-slim for a smaller base image.

firewave · 2026-06-18T11:56:41Z

    strategy:
      matrix:
-        image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23"]
+        image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23", "oraclelinux:8"]


Please use oraclelinux:8-slim for a smaller base image.

firewave · 2026-06-18T11:56:56Z

    /** List of registered check classes. This is used by Cppcheck to run checks and generate documentation */
    CPPCHECKLIB const std::list<Check *>& get();
-};
+}


I am curious why we did not see this warning in the CI before.

firewave · 2026-06-18T11:57:10Z

+// Hack to workaround GCC bug.
+// Details: https://trac.cppcheck.net/ticket/14850
+// seen on:
+// oraclelinux:8, g++-8.5
+// ubuntu:20.04, g++-9.4.0


This comment can be adjusted to g++ before 10.x as it is not distribution bound.

github-advanced-security AI found potential problems Jun 16, 2026

View reviewed changes

Comment thread lib/settings.h Fixed

danmar force-pushed the fix-14850 branch from f6a7f18 to 419e114 Compare June 16, 2026 11:55

firewave requested changes Jun 16, 2026

View reviewed changes

Fix #14850 (Compilation fails on oraclelinux:8 (g++ 8.5.0 released in…

34bd599

… 2021))

danmar force-pushed the fix-14850 branch from a7cae09 to 34bd599 Compare June 16, 2026 12:55

github-advanced-security AI found potential problems Jun 16, 2026

View reviewed changes

Comment thread lib/settings.h Fixed

format

bb014c5

cleanup

0850bef

rely on gcc version

50fec8e

cleanup

e4b2808

github-advanced-security AI found potential problems Jun 16, 2026

View reviewed changes

Comment thread lib/settings.h Fixed

Comment thread lib/settings.h Fixed

Comment thread lib/settings.h Fixed

danmar added 2 commits June 16, 2026 20:28

remove redundant semicolon

1c6d7dd

clang-tidy

82d06df

wjakobsson previously approved these changes Jun 17, 2026

View reviewed changes

danmar requested a review from Copilot June 17, 2026 08:30

Copilot started reviewing on behalf of danmar June 17, 2026 08:32 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

Comment thread lib/settings.h

Comment thread lib/settings.h Outdated

Comment thread lib/settings.cpp Outdated

Comment thread .github/workflows/CI-unixish-docker.yml

danmar added 2 commits June 17, 2026 10:41

rename

d557306

test

464427a

danmar dismissed wjakobsson’s stale review via 464427a June 17, 2026 08:44

github-advanced-security AI found potential problems Jun 17, 2026

View reviewed changes

comment

bcc6f21

firewave approved these changes Jun 17, 2026

View reviewed changes

firewave reviewed Jun 18, 2026

View reviewed changes

Conversation

danmar commented Jun 16, 2026

Uh oh!

Uh oh!

firewave left a comment

Choose a reason for hiding this comment

Uh oh!

firewave commented Jun 16, 2026

Uh oh!

danmar commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

danmar commented Jun 16, 2026

Uh oh!

firewave commented Jun 16, 2026

Uh oh!

danmar commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

firewave commented Jun 16, 2026

Uh oh!

danmar commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danmar commented Jun 17, 2026

Uh oh!

firewave commented Jun 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danmar commented Jun 17, 2026

Uh oh!

Uh oh!

firewave commented Jun 17, 2026

Uh oh!

firewave commented Jun 17, 2026

Uh oh!

firewave Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

firewave Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

firewave Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

firewave Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

danmar commented Jun 16, 2026 •

edited

Loading

danmar commented Jun 16, 2026 •

edited

Loading

danmar commented Jun 16, 2026 •

edited

Loading