Pinned linkify-it to 5.0.2 to address CVE#192
Open
MatthewJamisonJS wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug 🐛
Ran into GHSA-22p9-wv53-3rq4 —
linkify-ithas a ReDoS inmatch(), CVSS 8.7. We don't depend on it directly, it's pulled in twice throughmarkdown-it. Both copies (2.2.0and3.0.3) were below the patched5.0.1.Proposed Solution
Pinned it via yarn
resolutionsto^5.0.1, landed on5.0.2. Was a little worried since the changelog calls 5.0.0 an "ESM rewrite" — but looking at the published package, it still exports CJS (require→build/index.cjs.js) and the API surface (test,match,pretest,tlds) looks the same, so should be safe for our CJSmarkdown-itversions.Testing Notes
yarn why linkify-itshows one resolved copy at5.0.2now.yarn test:emberfails, but same failure happens onmainwithout this change (looks like a stale babel plugin in node_modules, not related to this).package.json+1 line,yarn.lock12+/13-, no full lockfile rewrite.