fix(clippy): inline format arg to un-red main (useless_borrows_in_formatting) - #413
Closed
byte-the-bot wants to merge 0 commit into
Closed
fix(clippy): inline format arg to un-red main (useless_borrows_in_formatting)#413byte-the-bot wants to merge 0 commit into
byte-the-bot wants to merge 0 commit into
Conversation
byte-the-bot
force-pushed
the
fix/clippy-useless-borrow-github-oauth
branch
from
August 4, 2026 08:13
1c446aa to
c6fdfdf
Compare
Collaborator
Author
|
This PR is now empty — nothing left to merge. I rebased it onto current main today and it came out at zero commits ahead, zero files changed: The Safe to close. I didn't close it myself since that's your call — say the word, or just hit close. Second one of these today: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Clippy 1.97 (CI's toolchain) promoted/enforced
useless_borrows_in_formattingand now flags the&oauth_responseborrow inside the decode-errorformat!ingithub_oauth.rs. This makes main itself red, so every open coreyja.com PR inherits the failure (#378, #398, #412, #392 all show a failing Lint check they didn't cause).Fix
Inline the format argument:
This drops the redundant borrow (satisfies clippy 1.97) and is also inlined (satisfies clippy 1.95, which wants
uninlined_format_args) — robust across the toolchain drift. Verifiedcargo clippy -p server --all-targetsandcargo fmt --checkclean locally.Why standalone
One-line, zero-risk fix that un-reds main and unblocks the whole PR queue at once, rather than folding it into any single feature PR.
🤖 Generated with Claude Code