feat(next): connect KGRAM producer to StorageManager#482
Open
remiceres wants to merge 9 commits into
Open
Conversation
|
Test Results 432 files 432 suites 20s ⏱️ Results for commit 0cffbf6. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
Implements a new KGRAM Producer backed by the Corese-next StorageManager, enabling query evaluation over the new storage layer without relying on the legacy Graph implementation (Issue #472).
Changes:
- Added
StorageManagerProducerto translate KGRAM triple patterns intoStatementPatternqueries againstStorageManager. - Added
StorageManagerEdgeas anEdgeview over storage-layerStatementresults. - Updated
CoreseAstQueryBuilderto mark compiled expressions as evaluable for execution, and added dedicated tests covering the new producer behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/java/fr/inria/corese/core/next/query/kgram/tool/StorageManagerProducerTest.java | Adds integration-style tests validating edge enumeration, context handling, and evaluation through Eval and the SPARQL bridge. |
| src/main/java/fr/inria/corese/core/next/query/kgram/tool/StorageManagerProducer.java | Introduces a StorageManager-backed KGRAM producer and basic BGP mappings materialization. |
| src/main/java/fr/inria/corese/core/next/query/kgram/tool/StorageManagerEdge.java | Adds an Edge adapter over storage Statement results for KGRAM consumption. |
| src/main/java/fr/inria/corese/core/next/query/impl/sparql/bridge/CoreseAstQueryBuilder.java | Ensures compiled WHERE expressions are marked for evaluation when building runtime Query objects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
|
Contributor
Author
|
Salut Abdessamad, j'ai fini d'étudier le code de la PR, d'ajouter les javadocs explicatives (sur le rôle de getMappings, join, et le BindingEnvironment/BindingSet) et de faire les correctifs. La PR est prête pour ta revue. Merci ! |
|
Contributor
Author
|
Oups, je la repasse temporairement en draft pour terminer quelques vérifications demain matin avant la revue finale. À demain ! |
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the storage-backed SPO/BGP path for the next KGRAM pipeline.
KGRAM can now query triples from the new
StorageManager, receive storage results as KGRAM edges, and materialize simple BGP mappings.Changes
Added
StorageManagerProducerStatementPatternqueries.Added
StorageManagerEdgeStatementresults as next KGRAMEdgeobjects.Added
StorageManagerKgramValuesValue, CoreseIDatatype, and next KGRAMNode.Added BGP mapping support
getMappings(...)now materializes basic graph patterns and joins repeated variables.Fixed predicate handling in the AST bridge
?s ?p ?oare correctly represented for KGRAM.Fixed graph/dataset handling
GRAPH <g>and activeFROMrestrictions to storage contexts.Fixed KGRAM fail semantics
Extended tests