runtime: fix process liveness and exec exit status reporting - #43
Merged
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
jankaluza
force-pushed
the
pr/zombie-detection
branch
2 times, most recently
from
July 29, 2026 09:47
9df668a to
c604074
Compare
simek-m
reviewed
Jul 31, 2026
jankaluza
force-pushed
the
pr/zombie-detection
branch
from
August 3, 2026 13:01
c604074 to
c01bc73
Compare
simek-m
reviewed
Aug 3, 2026
jankaluza
force-pushed
the
pr/zombie-detection
branch
from
August 4, 2026 10:53
c01bc73 to
a8dce1f
Compare
jankaluza
changed the title
jankaluza
force-pushed
the
pr/zombie-detection
branch
from
August 4, 2026 11:14
a8dce1f to
dfbe5b0
Compare
Member
Author
|
@simek-m , so this fixes the podman tests with conmon-v3. |
simek-m
reviewed
Aug 6, 2026
simek-m
reviewed
Aug 6, 2026
simek-m
reviewed
Aug 6, 2026
simek-m
approved these changes
Aug 6, 2026
simek-m
left a comment
simek-m
left a comment
There was a problem hiding this comment.
It looks good to me, if I understand the whole flow. Let's see how it turns out:)
jankaluza
force-pushed
the
pr/zombie-detection
branch
2 times, most recently
from
August 12, 2026 09:17
8b90e8e to
c1cbb8b
Compare
Member
Author
|
Rebased. |
Distinguish live processes from zombies via /proc instead of kill(pid, 0), and correctly capture fast-exiting exec status by registering the container PID before reaping pending children. Report timeout as -1 and stop the event loop once the container status is known. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
jankaluza
force-pushed
the
pr/zombie-detection
branch
from
August 12, 2026 10:25
c1cbb8b to
e0dee8b
Compare
Member
Author
|
And rebased once more :-). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish live processes from zombies via /proc instead of kill(pid, 0),
and correctly capture fast-exiting exec status by registering the container
PID before reaping pending children. Report timeout as -1 and stop the
event loop once the container status is known.