Remove dependency on github.com/opencontainers/runtime-tools - #305
Open
thaJeztah wants to merge 2 commits into
Open
Remove dependency on github.com/opencontainers/runtime-tools#305thaJeztah wants to merge 2 commits into
github.com/opencontainers/runtime-tools#305thaJeztah wants to merge 2 commits into
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
rm_runtime_tools
branch
from
August 11, 2026 22:56
0fffd32 to
37b64bc
Compare
This copies the implementation that was added in [containerd/nri@e01c004] as an internal package, so that we can remove the dependency on the (largely unmaintained) runtime-tools module, including its dependencies. [containerd/nri@e01c004]: containerd/containerd@e01c004 Co-authored-by: Tianon Gravi <tianon.gravi@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
rm_runtime_tools
branch
from
August 12, 2026 00:48
37b64bc to
6113b94
Compare
There was a problem hiding this comment.
Pull request overview
This PR removes the dependency on github.com/opencontainers/runtime-tools by copying the required OCI spec generator functionality into an internal package, and updating tests and module dependencies accordingly.
Changes:
- Added an internal OCI spec generator implementation (
pkg/runtime-tools/internal/ocigen) that satisfiespkg/runtime-tools/generate.UnderlyingGenerator. - Updated the
pkg/runtime-tools/generatetest suite to use the new internal generator instead ofruntime-tools/generate. - Removed
github.com/opencontainers/runtime-tools(and now-unneeded transitive deps) fromgo.mod/go.sum.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/runtime-tools/internal/ocigen/spec_generator.go | New internal generator implementing the UnderlyingGenerator interface directly over *specs-go.Spec. |
| pkg/runtime-tools/generate/helpers_other.go | Non-Linux stub signature adjusted while keeping behavior unchanged. |
| pkg/runtime-tools/generate/generate_suite_test.go | Tests updated to use internal/ocigen instead of upstream runtime-tools/generate. |
| pkg/adaptation/plugin_other.go | Non-Linux stub signature adjusted while keeping behavior unchanged. |
| go.mod | Drops the github.com/opencontainers/runtime-tools requirement (and an indirect dep). |
| go.sum | Removes checksums for now-unreferenced transitive dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
thaJeztah
marked this pull request as ready for review
August 12, 2026 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/opencontainers/runtime-toolscontainerd#13519This copies the implementation that was added in containerd@e01c004 as an internal package, so that we can remove the dependency on the (largely unmaintained) runtime-tools module, including its dependencies.