Skip to content

Allow configuring request timeout per plugin - #304

Open
CoderSherlock wants to merge 1 commit into
containerd:mainfrom
CoderSherlock:feature/per-plugin-request-timeout
Open

Allow configuring request timeout per plugin#304
CoderSherlock wants to merge 1 commit into
containerd:mainfrom
CoderSherlock:feature/per-plugin-request-timeout

Conversation

@CoderSherlock

Copy link
Copy Markdown

Support per-plugin request timeout in NRI while maintaining global timeout as the default fallback.

  • Add request_timeout field (in milliseconds) to ConfigureResponse protobuf message.
  • Update adaptation layer to store per-plugin request timeout on configuration response and use it across plugin request invocations.
  • Add WithRequestTimeout option and SetRequestTimeout method to plugin stub interface to allow plugins to specify a custom timeout.
  • Add unit test verifying per-plugin request timeout configuration.

Fixes #287

Support per-plugin request timeout in NRI while maintaining global
timeout as the default fallback.

- Add request_timeout field (in milliseconds) to ConfigureResponse protobuf message.
- Update adaptation layer to store per-plugin request timeout on configuration response and use it across plugin request invocations.
- Add WithRequestTimeout option and SetRequestTimeout method to plugin stub interface to allow plugins to specify a custom timeout.
- Add unit test verifying per-plugin request timeout configuration.

Fixes containerd#287

Signed-off-by: Pengzhan Hao <haopengzhan@gmail.com>
@CoderSherlock
CoderSherlock force-pushed the feature/per-plugin-request-timeout branch from 04227c7 to 64caddc Compare August 7, 2026 18:23
@CoderSherlock CoderSherlock changed the title feat: Allow configuring request timeout per plugin Allow configuring request timeout per plugin Aug 7, 2026
@CoderSherlock

Copy link
Copy Markdown
Author

/reviewer @samuelkarp @mikebrow

@mikebrow

Copy link
Copy Markdown
Member

wave..see comment #287 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Allow configuring request timeout per plugin instead of using a single global timeout

2 participants