KEP-5943: Introducing Snapshot Topology#606
Open
mdzraf wants to merge 1 commit into
Open
Conversation
4 tasks
Author
|
/assign @bswartz |
mdzraf
changed the title
Contributor
|
Do we need to add some constraints for TopologyRequirement in CreateVolumeRequest if VolumeContentSource is a Snapshot? |
gnufied
reviewed
Jul 1, 2026
Author
We can discuss this but we will already be enforcing it at provisioning time via the external-provisioner and the custom scheduler plugin. |
mdzraf
commented
Jul 9, 2026
| @@ -2037,7 +2070,7 @@ The CO MUST implement the specified error recovery behavior when it encounters t | |||
| |-----------|-----------|-------------|-------------------| | |||
| | Snapshot already exists but is incompatible | 6 ALREADY_EXISTS | Indicates that a snapshot corresponding to the specified snapshot `name` already exists but is incompatible with the specified `volume_id`. | Caller MUST fix the arguments or use a different `name` before retrying. | | |||
Author
There was a problem hiding this comment.
13 Is not the right number for RESOURCE_EXHAUSTED this is fixed in #605, hence why the number change here as well instead of a separate entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Introducing Snapshot Topology to CSI Spec.
What this PR does / why we need it:
This PR is part of the changes necessary for kubernetes/enhancements#5944
Special notes for your reviewer:
Does this PR introduce an API-breaking change?: