fix(pgpm): make default roles map match opt-in client role bootstrap#1367
Merged
Conversation
…it in client role generator
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since
authenticated_clientbecame opt-in (pgpm admin-users bootstrap --client), the defaultrolesmap returned bygetConnEnvOptions()still advertised it, so consumers that verify every role in the map after a default bootstrap fail (e.g. constructive-db'sfun-k8sk8s e2e:Required roles not found: authenticated_client).Reconcile the two:
@pgpmjs/typesdefaults: dropauthenticatedClientfrom the defaultrolesmap — it only lists roles the default bootstrap actually creates. TheRoleMapping.authenticatedClientfield remains for explicit configuration.@pgpmjs/coregenerateCreateClientRoleSQL: default to'authenticated_client'whenroles.authenticatedClientis unset, sobootstrap --clientkeeps working without explicit config:Once published, the temporary patch in constructive-db (
fun-k8scallingbootstrapClientRoleexplicitly, added in constructive-io/constructive-db#2133) can be reverted.Tests: updated
roles-sql-generatorstest (missingauthenticatedClientnow defaults instead of throwing) and the@pgpmjs/envmerge snapshot.Link to Devin session: https://app.devin.ai/sessions/8fee29d00c194dfabfcaa221dcbe1bcb
Requested by: @pyramation