Concept sets with few lists and replacement concept sets#1536
Merged
Conversation
AnnikaTjuka
reviewed
Jul 9, 2026
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
Collaborator
There was a problem hiding this comment.
Just one minor addition.
| 4179 CUBE The physical world A three-dimensional solid object with six equal square faces, twelve equal edges, and eight vertices. Person/Thing | ||
| 4180 FACTORY Modern world A building or group of buildings where goods are manufactured or assembled, typically using machinery and organized labor processes. Person/Thing No newline at end of file | ||
| 4180 FACTORY Modern world A building or group of buildings where goods are manufactured or assembled, typically using machinery and organized labor processes. Person/Thing | ||
| 4181 NEED OR NECESSITY Cognition A condition or state in which something is required or essential for a person or system to function, survive, or achieve a goal. Person/Thing No newline at end of file |
Collaborator
There was a problem hiding this comment.
Could you add the semantic relation to 643 NEED (NOUN)?
Collaborator
Author
There was a problem hiding this comment.
Sure! You mean in conceptrelations.tsv?
Collaborator
Author
|
Added! |
AnnikaTjuka
approved these changes
Jul 15, 2026
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
This PR serves to replace concept sets with very few mappings with more fitting/frequent concept sets.
Among other things, concept set 4181 NEED OR NECESSITY was added, occurences of "effort" were mapped to 2525 WORK (LABOUR) and the description for 532 GIPSY was updated.