docs(adapters): define source adapter specification - #15
Merged
Conversation
Define the host-neutral adapter contract, the initial GitHub profile, upstream reuse boundaries, and explicit complexity guardrails. Record the remaining review questions without changing the earlier exploration document. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Specify complete deletion, human-review modification, immutable source, assertion provenance, and commit-preservation behavior. Separate the target contract from current implementation gaps and remove provisional versioning. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Treat deletion and review scope as ordinary pull-request changes, bind mutable sources by identifier and content hash, and make DataLad optional for later programmatic edits. Attribute each bot commit to its triggering human. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Expose DataLad through the review-application Pixi task without making it the default for human-driven edits. Remove the resolved choice from the open questions. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Require DataLad for Pixi-applied metadata changes and place the no-squash requirement in the adapter pull-request opening text. Leave source-content canonicalization as an explicit review question. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Treat a reviewed human correction as an ownership transfer. Preserve it during later source runs and surface upstream disagreement as a diagnostic rather than a proposed reversion. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Hash only normalized source facts that can affect proposed metadata and route all adapter YAML through one schema-aware canonicalizer. Clarify human review as the merge authority and define baseline interaction between adapters. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Normalize the existing corpus once, preserve list order by default, and keep semantic comparison separate from YAML serialization. Permit clean adapter rebases while requiring conflicting proposals to rerun, and retain only the most recently accepted source PAV. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Require merge commits or true fast-forwards for accepted adapter lineages. Permit independent branches to merge in either order, regenerate overlapping proposals, and treat the canonical corpus as an established precondition. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Let ordinary Git determine whether independent adapter proposals compose cleanly. Require regeneration only after a merge conflict and avoid introducing a separate semantic-conflict analyzer. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Make merge commits a downstream prerequisite, base review invalidation only on changed output, and keep validation errors out of durable decision state. Remove redundant commit trailers and move implementation gaps out of the normative specification. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Adopt Dump Things mapping order and list preservation, require complete source and Things validation, and map the reused upstream primitives. Record deliberate ownership, deletion, retained-proposal, and source coordinate deviations. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Compare assertion semantics independently of PAV. Preserve existing ownership when an incoming assertion is identical, and transfer PAV only with an accepted substantive assertion change. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Replace the exploratory source-adapters document with the reviewed host-neutral contract and retain only useful non-normative design notes. Store machine PAV in mirrored metadata provenance companions that join with user-facing records for validation and RDF export. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Name metadata/overlays/annotations as the sole semantic overlay for adapter PAV companions. Reserve any additional overlay for a focused specification change with deterministic join and validation rules. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Promote the reviewed source-adapter contract from a draft reference. Require clarification before material ambiguity expands authority, durable state, the threat model, or implementation architecture. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Replace the superseded inventory and transaction exploration with a concise implementation and acceptance wrapper around the normative source-adapter contract. Record the accepted hosted review, disposition, merge-history, and annotation-overlay decisions, and make Milestone 5 the active effort. Co-Authored-By: Codex Desktop 26.814.41407 (runtime codex-cli 0.148.0-alpha.15) / gpt-5.6-sol <codex@openai.com> Codex-Reasoning-Effort: ultra
Collaborator
Author
|
"currently being on the old unmerged 218-record adapter branch" consumer will be updated rewritten by the implementation of this more precise spec. |
leej3
marked this pull request as ready for review
August 20, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI-generated draft — not reviewed by John
Summary
docs/source-adapters.mdas the normative host-neutral source-adapter specification.metadata/records/and machine PAV in mirroredmetadata/overlays/annotations/companions that join into the same semantic graph.Review focus
Scope
Validation
git diff --checkpassed.pixi run test-development: 40 tests passed.test-enginereached 49 passing tests; its full-fidelity projection case was blocked by the hard-coded sibling consumer checkout currently being on the old unmerged 218-record adapter branch. Hosted clean-checkout CI is running.