add another example of a race abbreviation - #182
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
chohlasa
left a comment
chohlasa
left a comment
There was a problem hiding this comment.
@muskankwalia Looks great!
I have only one small set of requested changes: can you change the “curly double-quotes” to "non-curly double quotes"? You might need to update the lines you changed on the last commit also.
(I'm curious where you drafted this—maybe Word?—just for my own knowledge about where non-curly double quotes get converted to curly versions!)
|
@chohlasa word --> sublime --> repo .txt file. looks like when i pasted stuff over from word to sublime it kept them curly, so they also showed up on the previous branch we were working on. fixed. thanks for catching that — i didn't notice it! |
|
Yes, it's very subtle. It's unclear if they'd make any difference but I'd just prefer base ASCII characters whenever possible, since there's a small chance they will do better with tokenization. Thanks for fixing! |
2 participants
No description provided.