Auto-advance activation after managed ENS verification#389
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07ab9b851b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await db.query( | ||
| `update claim_requests | ||
| set managed_ens_publication_status = 'verified', tenant_signer_record_status = 'records_verified', | ||
| set managed_ens_publication_status = 'verified', tenant_signer_record_status = 'verified', |
There was a problem hiding this comment.
Preserve the submit-compatible signer status
Setting managed-ENS claims to the new tenant_signer_record_status = 'verified' leaves them incompatible with the tenant receipt-submission flow: api/claims/submit-first-action-receipt.js still rejects anything other than records_verified before verifying the signed first-action receipt. In the managed flow this endpoint now generates a challenge successfully, but the tenant cannot submit the signed receipt until another path rewrites the status, so use the existing records_verified value or update all consumers that gate on it.
Useful? React with 👍 / 👎.
Motivation
Description
POST /api/admin/verify-managed-ens-publicationto mark managed ENS and tenant signer records as verified, set verification timestamps, clear errors, and then invoke the existing activation orchestrator to attempt safe post-ENS steps; the endpoint returns anadvancedobject describing what advanced. (file:api/admin/verify-managed-ens-publication.js)already_generated), preservingverified/challenge_readyfirst-action receipt states, and attempting to generate a first-action challenge when prerequisites are met. It also collectserrorsper sub-step. (file:api/admin/run-activation-pipeline.js)tenant_signer_record_status = 'verified'as equivalent torecords_verifiedin first-action preflight and public status logic, so auto-advancement enables downstream steps. (files:api/admin/generate-first-action-receipt.js,api/claims/status.js)Verify ENS TXT recordsshowing Managed ENS, agent card pinning, genesis generation, first-action receipt status, and advancement errors without marking managed ENS verification as failed on downstream failures. (file:public/admin/claims.html)tests/managed-ens-publication.test.js)Testing
npm testand all tests passed (167tests run in this workspace); the updated and new tests covering verification advancement and idempotency passed.npm run check:linksand link checks succeeded.Codex Task