Fix admin claims loader to handle current API response shape#361
Open
GsCommand wants to merge 1 commit into
Open
Fix admin claims loader to handle current API response shape#361GsCommand wants to merge 1 commit into
GsCommand wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
d.okto be truthy and treated valid responses like{ claims: [...] }as failures.Load claimsactually loads and renders claims fromGET /api/admin/claimswithout changing payment, webhook, validation, or auth behavior.Description
public/admin/claims.htmlto robustly parseGET /api/admin/claimsresponses by reading the raw response, safe-parsing JSON, and acceptingArrayor{ claims: [...] }shapes, while treating onlyd?.ok === falseor non-2xx transport as an application error.Load failed: <status> — <error or response text>and the page no longer remains stuck on "Loading claims...".GET /api/admin/claim?claimId=...so row clicks surface errors instead of silently failing.ADMIN_API_KEY.Testing
npm testand all tests passed (82tests passing).npm run check:linksand it reported all local links/assets resolved across HTML files.cd examples/webhook-auto-verify && npm run checkand the example checks passed.Codex Task