Fix release workflow secrets guard; bump version to 0.2.0 - #73
Open
cognitivegears wants to merge 1 commit into
Open
Fix release workflow secrets guard; bump version to 0.2.0#73cognitivegears wants to merge 1 commit into
cognitivegears wants to merge 1 commit into
Conversation
The secrets context is not allowed in step-level if: expressions — the guards added in 7b30a2a made GitHub reject the whole workflow file at plan time, so the v0.2.0 tag produced no release run (no jar upload, no version bump). The presence check is hoisted into a job-level env var, which IS allowed to read secrets. The version bump the workflow would have pushed is included here since the v0.2.0 tag event has already fired. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secretscontext is not allowed in step-levelif:expressions; the guards added in 7b30a2a made GitHub rejectrelease.ymlat plan time, so thev0.2.0tag push produced a 0-second workflow-file failure — no jar upload and no version bump.envvar (HAS_SIGNING_KEY), where reading secrets is allowed, and guards the two publish steps on it.pom.xmlto 0.2.0 — the commit the workflow would have pushed had it run (the tag event has already fired).The v0.2.0 release itself is already complete: notes published and both jars (built from this branch at version 0.2.0, CLI smoke-tested) uploaded manually. This PR just makes the next tagged release work end to end.
🤖 Generated with Claude Code