feat(grouper): propagate occurrence count to totalCount and repetitions#573
Draft
Reversean wants to merge 1 commit into
Draft
feat(grouper): propagate occurrence count to totalCount and repetitions#573Reversean wants to merge 1 commit into
Reversean wants to merge 1 commit into
Conversation
- event-worker / javascript-worker: forward CatcherMessage.count to the grouper task instead of dropping it - grouper: use count instead of a hardcoded 1 when - setting totalCount on first occurrence - incrementing totalCount on repetitions - incrementing the daily events aggregate - grouper: record count on the repetition document itself, omitted when absent or 1 (single occurrence), set when a message represents more than one real occurrence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grouper task instead of dropping it
absent or 1 (single occurrence), set when a message represents more
than one real occurrence
Draft: depends on @hawk.so/types publishing CatcherMessage.count /
RepetitionDBScheme.count (codex-team/hawk.types#76).