feat: add Yandex Metrica message processor and corresponding test#192
Open
Dobrunia wants to merge 6 commits into
Open
feat: add Yandex Metrica message processor and corresponding test#192Dobrunia wants to merge 6 commits into
Dobrunia wants to merge 6 commits into
Conversation
…unters and preserve queue positions
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Browser SDK addon that enriches outgoing error payloads with Yandex Metrica identifiers (counterId + clientId) when Metrica is present, and adds test coverage for this behavior.
Changes:
- Introduces
YandexMetricaAddonMessageProcessorthat reads up to 10 counters from the Metrica init queue and caches{ counterId, clientId }for later payload enrichment. - Wires the new processor into the browser
Catchermessage processing pipeline. - Adds unit + integration tests validating identifier attachment behavior and edge cases.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/browser/tests/catcher.addons.test.ts | Adds an integration test asserting Yandex Metrica identifiers appear in outgoing payload addons. |
| packages/browser/tests/addons/yandex-metrica-message-processor.test.ts | Adds unit tests for the Yandex Metrica addon message processor behavior and edge cases. |
| packages/browser/src/catcher.ts | Registers the Yandex Metrica message processor in the browser Catcher pipeline. |
| packages/browser/src/addons/yandex-metrica-addon-message-processor.ts | Implements Yandex Metrica identifier discovery + caching and payload enrichment. |
| packages/browser/package.json | Bumps browser package version to 3.4.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2
to
+5
| import { | ||
| YANDEX_METRICA_ADDON_KEY, | ||
| YandexMetricaAddonMessageProcessor | ||
| } from '../../src/addons/yandex-metrica-addon-message-processor'; |
Comment on lines
+71
to
+92
| vi.stubGlobal('ym', ym); | ||
|
|
||
| const { sendSpy, transport } = createTransport(); | ||
|
|
||
| createCatcher(transport).send(new Error('e')); | ||
| await wait(); | ||
|
|
||
| expect(getLastPayload(sendSpy).addons.yandexMetrica).toEqual({ | ||
| ['1']: { | ||
| counterId: 123, | ||
| clientId: 'client-123', | ||
| }, | ||
| ['2']: { | ||
| counterId: 456, | ||
| clientId: 'client-456', | ||
| }, | ||
| }); | ||
| expect(ym).toHaveBeenCalledWith(123, 'getClientID', expect.any(Function)); | ||
| expect(ym).toHaveBeenCalledWith(456, 'getClientID', expect.any(Function)); | ||
|
|
||
| vi.unstubAllGlobals(); | ||
| }); |
neSpecc
reviewed
Jun 23, 2026
| /** | ||
| * Addon key used to attach Yandex Metrica identifiers. | ||
| */ | ||
| export const YANDEX_METRICA_ADDON_KEY = 'yandexMetrica'; |
Member
There was a problem hiding this comment.
could you rename it to yandexMetrika?
|
|
||
| const MAX_YANDEX_METRICA_COUNTERS = 10; | ||
|
|
||
| interface YandexMetricaFunction { |
| */ | ||
| export class YandexMetricaAddonMessageProcessor implements MessageProcessor<'errors/javascript'> { | ||
| /** | ||
| * Cached Yandex Metrica identifiers keyed by their one-based queue position. |
Member
There was a problem hiding this comment.
explain what is "identifier"? is it counter id? of so, why do you use another naming
| /** | ||
| * Reads up to ten initialized counters and requests their ClientIDs. | ||
| */ | ||
| constructor() { |
Member
There was a problem hiding this comment.
please organize business logic by separate methods, and add try-catch where it is needed
neSpecc
reviewed
Jun 23, 2026
neSpecc
left a comment
neSpecc
left a comment
Member
There was a problem hiding this comment.
- update README as well
- also please fix this broken link in readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new addon - Yandex Metrica.
Send 2 new fields: