Implement File storage in file system#680
Draft
SalmaElsoly wants to merge 8 commits into
Draft
Conversation
SalmaElsoly
marked this pull request as ready for review
October 19, 2025 06:38
rawdaGastan
requested changes
Oct 22, 2025
| if err != nil { | ||
| return Configuration{}, fmt.Errorf("failed to expand file storage base directory path: %w", err) | ||
| } | ||
| if _, err := os.Stat(config.FileStoragePath); os.IsNotExist(err) { |
Contributor
There was a problem hiding this comment.
I think this is checked in expandPath? no?
Contributor
Author
There was a problem hiding this comment.
no, expand path only expands tilde and converts to absolute path, it doesn't check if path exist or not
SalmaElsoly
force-pushed
the
master_filestorage
branch
2 times, most recently
from
October 23, 2025 12:33
5a5e59d to
2256595
Compare
SalmaElsoly
force-pushed
the
master_filestorage
branch
from
November 10, 2025 14:39
2256595 to
c854c4c
Compare
SalmaElsoly
marked this pull request as draft
November 17, 2025 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
Related Issues
#673
Checklist