Unifying art branches#155
Open
samjjacko wants to merge 151 commits into
Open
Conversation
…/game-dev into issue-8/art-page
…flict Issue 8 resolve merge conflict
…play artwork on individual member's pages properly
laurenpudz
requested changes
Jul 11, 2026
laurenpudz
left a comment
laurenpudz
left a comment
Contributor
There was a problem hiding this comment.
corrections/reminders for me when I'm going through this PR to fix stuff
Contributor
There was a problem hiding this comment.
Need to check if this is actually getting used or not
| sm: "h-9 rounded-md px-3", | ||
| lg: "h-11 rounded-md px-8", | ||
| icon: "h-10 w-10", | ||
| leftIcon: "h-10 ps-2 pe-4 py-2 flex gap-2", |
Contributor
There was a problem hiding this comment.
Check if all of these classes are necessary
| return Array.isArray(v.results); | ||
| } | ||
|
|
||
| const PLACEHOLDER_ICON = ( |
Contributor
There was a problem hiding this comment.
should be able to take out placeholders
| return ( | ||
| <div className="bg-gamedev-dark min-h-screen"> | ||
| <section className="px-6 py-10 md:px-24 md:py-14"> | ||
| <h1 className="text-light_3 justify-start text-center font-jersey10 text-6xl font-bold leading-[76px] tracking-wide text-primary"> |
Contributor
There was a problem hiding this comment.
why specifically 76px? if not, utility class
| if (isError || !member) { | ||
| return <p>Member not found</p>; | ||
| } | ||
| console.log(gamesRes.data); |
SafetyInObscurity
force-pushed
the
unifying_art_branches
branch
from
18e454e to
69cff9f
Compare
SafetyInObscurity
force-pushed
the
unifying_art_branches
branch
from
69cff9f to
c9c1823
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Merges the primary art branches
issue-8-merge-40andissue-81-Art_in_GameSerializer_Data, as well as contributors documentation, events documentation, and any other documentation branch I could findChange Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
Some code (particularly for individual member pages) is not particularly DRY, but the code isn't reused anywhere and shouldn't affect maintenance realistically.