Skip to content

feat: distinguish 404 permanent failures from temporary API errors - #535

Open
Yashaswini-K-P wants to merge 1 commit into
codepvg:mainfrom
Yashaswini-K-P:feature/handle-fetch-status-codes
Open

feat: distinguish 404 permanent failures from temporary API errors#535
Yashaswini-K-P wants to merge 1 commit into
codepvg:mainfrom
Yashaswini-K-P:feature/handle-fetch-status-codes

Conversation

@Yashaswini-K-P

Copy link
Copy Markdown
Contributor

Description

Updated scripts/analyze-inactivity.js to distinguish between temporary API errors and permanent account deletions, routing 404 errors into invalid-users.json for manual verification.

Linked Issue

Fixes #353

Changes Made

  • Updated fetchData to return { data, status }.
  • Implemented logic to read, merge, and alphabetically sort entries in invalid-users.json.
  • Separated 404 permanent account failures from temporary network/server failures in the sync loop.

Type of Change

  • Bug fix
  • New feature
  • UI/Visual update
  • Documentation update
  • Refactor

Testing

  • Tested locally
  • Tested on mobile viewport (if applicable)
  • No console errors introduced

Checklist

  • My code follows the project's coding style
  • I have formatted my code locally by running npx prettier --write . before submitting
  • I am submitting my PR from a dedicated feature/* branch, not the main branch
  • I have performed a self-review of my code
  • My changes generate no new warnings or errors
  • I have updated documentation if required
  • I have linked the relevant issue

Screenshots / Screen Recording

N/A (Backend synchronization logic update)

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for submitting a pull request.

Please ensure your changes comply with the project's contribution guidelines and that all workflow checks pass successfully.

Formatting and Branching

  • Please confirm you have formatted your code locally using npx prettier --write . before requesting a review.
  • Ensure this PR is made from a feature/* branch and not main.

Note: This project is currently maintained by a solo maintainer, so reviews and responses may sometimes take a little time. Thanks for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Distinguish Between "API Error" and "User Not Found"

1 participant