Optimize justfile with grouped recipes and typed deploy-api flags#83
Conversation
…api flags Reorganize the project command surface around just groups, documentation attributes, and composite recipes (ci, ci-full, fix, dev-api-fresh). Add Cloudflare local inspection helpers via just/cloudflare.just, guard reset-api-state with confirmation, and expose nix-check/nix-fmt recipes. deploy-api now uses --env/--dry-run/--confirm flags instead of ENV= style assignments. Update docs, CI workflows, and deploy-api tests accordingly. Co-authored-by: Kazuno Fukuda <codemountains@gmail.com>
Co-authored-by: Kazuno Fukuda <codemountains@gmail.com>
Co-authored-by: Kazuno Fukuda <codemountains@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 593f863322
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Clear legacy deploy env vars in the just recipe and read confirmation and dry-run state from BARESTASH_DEPLOY_* variables instead. Add regression tests that exported CONFIRM/DRY_RUN no longer bypass --confirm or --dry-run. Co-authored-by: Kazuno Fukuda <codemountains@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97c5703e68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The justfile uses set default-list (1.52+) and set minimum-version (1.55+), so the declared floor must match the newest required feature. Co-authored-by: Kazuno Fukuda <codemountains@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6da91a582
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Stop accepting ambient ENV for deploy-api side effects. The just recipe now exports BARESTASH_DEPLOY_ENV and clears legacy ENV, matching the BARESTASH_DEPLOY_* contract used for confirm and dry-run flags. Co-authored-by: Kazuno Fukuda <codemountains@gmail.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c69d9cb59d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Prevent shell re-parsing of operator SQL before Wrangler receives the --command argument. Co-authored-by: Kazuno Fukuda <codemountains@gmail.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
Restructures the repository command surface around a documented, grouped justfile and breaks the old
ENV=/DRY_RUN=deploy syntax in favor of typed flags.Changes
[group]/[doc]metadata,set default-list, andset minimum-version := "1.46.0"ci,ci-full,fix,dev-api-fresh,nix-check,nix-fmtreset-api-statewith[confirm]just/cloudflare.just(d1-query,r2-get)deploy-apito--env,--dry-run, and--confirmscripts/deploy-api.ts, tests, README/docs, and GitHub Actions to use the new just surfaceNew command examples
Verification
just --fmt --checkjust ci(203 tests, coverage report generated)pnpm exec vitest run scripts/deploy-api.test.ts(7 tests)Residual risk
code-reviewersubagent was unavailable in this environment; review was limited to local verification above.extractions/setup-just@v3; first run on GitHub will confirm action availability.