Add authentication domain persistence foundation#111
Merged
Conversation
codemountains
marked this pull request as ready for review
July 12, 2026 13:20
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dc9f2b9e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #103. Contributes the P1 foundation tracked by #110 without implementing the P2-P7 authentication flows in #104-#109.
The later scoped-PAT, authorization, browser auth, Device Authorization, and CLI session phases need a stable persistence and shared-contract boundary. This PR adds that boundary while keeping the current token-only runtime operational.
Changes
tokenstable and keep Better Auth adapter tables outside the API migration boundaryAuthPrincipal, credential metadata, account/device/refresh/PAT API contracts, and structured auth error codesapp.{domain}worker boundary, provider-token non-persistence, legacy-token migration staging, and GitHub CLI-style--insecure-storagefallback behaviorDocumentation and contracts
requirements/barestash.spec.mdrequirements/barestash-cli-design.spec.mddocs/The authentication source of truth in
requirements/barestash-authentication-authorization.spec.mdis also updated.Security and data handling
Provider access/refresh tokens and raw Barestash credentials have no persistence columns in the new domain schema. Repository fixtures contain synthetic hashes only.
Verification
Skipped checks or residual risk:
Review notes
code-reviewerfound one Medium issue: the in-memory adapter initially did not mirror D1 uniqueness and foreign-key failures. This was fixed with shared constraint-parity tests and complete create-time constraint enforcement; focused re-review confirmed the finding is resolved with no remaining findings.