Skip to content

Add GitHub ribbons - #225

Open
siddhpant wants to merge 1 commit into
coala:masterfrom
siddhpant:add-GitHub-ribbons
Open

Add GitHub ribbons#225
siddhpant wants to merge 1 commit into
coala:masterfrom
siddhpant:add-GitHub-ribbons

Conversation

@siddhpant

Copy link
Copy Markdown
Member

Closes #24.

Used http://tholman.com/github-corners/ as it's used in some other coala repos and was also suggested in the issue discussion.

@TravisBuddy

This comment has been minimized.

Comment thread templates/model/templates/ribbon.html Outdated
Comment thread templates/ribbon.html Outdated
@TravisBuddy

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

Comment thread templates/ribbon.html Outdated
Comment thread templates/model/templates/ribbon.html Outdated
@TravisBuddy

This comment has been minimized.

Comment thread templates/model/templates/ribbon.html Outdated
Comment thread templates/ribbon.html
Comment thread templates/model/templates/base.html Outdated
Comment thread templates/ribbon.html Outdated
@TravisBuddy

This comment has been minimized.

@SerekKiri SerekKiri left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jayvdb

jayvdb commented Nov 29, 2018

Copy link
Copy Markdown
Member

@gitmate-bot rebase

@gitmate-bot

Copy link
Copy Markdown
Collaborator

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@gitmate-bot

Copy link
Copy Markdown
Collaborator

Automated rebase with GitMate.io was successful! 🎉

Comment thread templates/ribbon.html Outdated
Comment thread templates/model/templates/base.html Outdated
@TravisBuddy

This comment has been minimized.

@TravisBuddy

This comment has been minimized.

@siddhpant siddhpant changed the title WIP: Add GitHub ribbons Add GitHub ribbons Dec 4, 2018
Comment thread templates/ribbon.html Outdated
@TravisBuddy

This comment has been minimized.

@li-boxuan li-boxuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siddhpant

Copy link
Copy Markdown
Member Author

Done

@li-boxuan li-boxuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there 👍

Comment thread community/settings.py Outdated

@li-boxuan li-boxuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment thread data/templatetags/ribbon_link.py
@TravisBuddy

Copy link
Copy Markdown

Travis tests have failed

Hey @siddhpant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

coala --non-interactive -V
[ERROR][07:14:47] There is a conflict in the version of a dependency you have installed and the requirements of coala. This may be resolved by creating a separate virtual environment for coala or running `pip3 install "git-url-parse~=1.1.0"`. Be aware that the latter solution might break other python packages that depend on the currently installed version.
[INFO][07:14:47] Exception was:
Traceback (most recent call last):

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/coala_main.py", line 147, in run_coala
    args=args)

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/settings/ConfigurationGathering.py", line 504, in gather_configuration
    targets=targets,

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/settings/SectionFilling.py", line 97, in fill_settings
    bear_dirs = section.bear_dirs()

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/settings/Section.py", line 147, in bear_dirs
    for bear_dir in collect_registered_bears_dirs('coalabears')]

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/coalib/collecting/Collectors.py", line 456, in collect_registered_bears_dirs
    registered_package = ep.load()

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2404, in load
    self.require(*args, **kwargs)

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/pkg_resources/__init__.py", line 2427, in require
    items = working_set.resolve(reqs, env, installer, extras=self.extras)

  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/pkg_resources/__init__.py", line 875, in resolve
    raise VersionConflict(dist, req).with_context(dependent_req)

pkg_resources.VersionConflict: (git-url-parse 1.2.0 (/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages), Requirement.parse('git-url-parse~=1.1.0'))
TravisBuddy Request Identifier: 685c3730-2c3a-11e9-b3d3-256864349aa7

@siddhpant

siddhpant commented Feb 9, 2019

Copy link
Copy Markdown
Member Author

Travis fails due to new version of git-url-parse being available (1.2.0)

#237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

8 participants