Skip to content

chore: Public types contract linter util#4669

Open
pan-kot wants to merge 1 commit into
mainfrom
refactor-public-interfaces-3
Open

chore: Public types contract linter util#4669
pan-kot wants to merge 1 commit into
mainfrom
refactor-public-interfaces-3

Conversation

@pan-kot

@pan-kot pan-kot commented Jun 25, 2026

Copy link
Copy Markdown
Member

Description

A follow-up for #4646 and #4667.

Rel: D475262969, iu7zAZtdKN3Z

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.57%. Comparing base (1716d82) to head (b868696).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4669   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         948      948           
  Lines       30489    30489           
  Branches    11148    11148           
=======================================
  Hits        29749    29749           
  Misses        733      733           
  Partials        7        7           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pan-kot pan-kot marked this pull request as ready for review June 26, 2026 07:08
@pan-kot pan-kot requested a review from a team as a code owner June 26, 2026 07:08
@pan-kot pan-kot requested review from NathanZlion and removed request for a team June 26, 2026 07:08

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) Have we checked no consumer imports this, we did a backwards compatible change for the internal/types. Is this safe to move?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants