Add cloud logging service feature#1847
Open
Yavor16 wants to merge 4 commits into
Open
Conversation
# Conflicts: # multiapps-controller-process/src/main/resources/org/cloudfoundry/multiapps/controller/process/backup-existing-app.bpmn # multiapps-controller-process/src/main/resources/org/cloudfoundry/multiapps/controller/process/deploy-app.bpmn # multiapps-controller-process/src/main/resources/org/cloudfoundry/multiapps/controller/process/stop-dependent-modules.bpmn # multiapps-controller-process/src/main/resources/org/cloudfoundry/multiapps/controller/process/undeploy-app.bpmn
Yavor16
force-pushed
the
export-logs-to-logging-service-squash
branch
from
20788df to
7220532
Compare
Yavor16
force-pushed
the
export-logs-to-logging-service-squash
branch
from
c1abde6 to
bb7fc04
Compare
Comment on lines
+294
to
+296
| InputStream serverCaStream = getCredentialInputStream(loggingConfiguration.getServerCa()); | ||
| InputStream clientCertStream = getCredentialInputStream(loggingConfiguration.getClientCert()); | ||
| InputStream clientKeyStream = getCredentialInputStream(loggingConfiguration.getClientKey()); |
Contributor
There was a problem hiding this comment.
are these streams closed?
IvanBorislavovDimitrov
left a comment
IvanBorislavovDimitrov
left a comment
Contributor
There was a problem hiding this comment.
Additional comments on OperationLogsExporter not yet covered in the earlier review.
|
theghost5800
requested changes
Jun 17, 2026
Comment on lines
+866
to
+875
| <dependency> | ||
| <groupId>io.projectreactor.netty</groupId> | ||
| <artifactId>reactor-netty-http</artifactId> | ||
| <version>${reactor-netty.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>io.projectreactor.netty</groupId> | ||
| <artifactId>reactor-netty-core</artifactId> | ||
| <version>${reactor-netty.version}</version> | ||
| </dependency> |
Contributor
There was a problem hiding this comment.
Why these dependencies are required? WebClient provided by spring webflux isn't it enough?
Contributor
Author
There was a problem hiding this comment.
I use HttpClient in CloudLoggingServiceHttpClient which required these dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.