Don't submit chat input on Enter during IME composition - #140
Open
chaspy wants to merge 1 commit into
Open
Conversation
When typing with an IME (Japanese, Chinese, Korean, etc.), pressing Enter to confirm a text conversion would send the message instead of just committing the composition. Check KeyboardEvent.isComposing on the chat send, slash-command picker, and chat rename Enter handlers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When typing with an IME (Japanese, Chinese, Korean, etc.), pressing Enter to confirm a text conversion sends the chat message instead of just committing the composition. This makes the chat input nearly unusable for CJK users.
Fix
Check
KeyboardEvent.isComposingbefore treating Enter as submit, in three places inChatInterface.tsx:6 insertions, 4 deletions. Verified locally with a Japanese IME: Enter during conversion now only commits the composition; Enter after conversion sends as before.
🤖 Generated with Claude Code