Add bzlmod support (MODULE.bazel)#1345
Merged
Merged
Conversation
Migrate from WORKSPACE to bzlmod for dependency management: - Add MODULE.bazel with rules_jvm_external and maven dependencies - Remove WORKSPACE, add empty WORKSPACE.bzlmod - Update CI workflow triggers from WORKSPACE to MODULE.bazel - Replace expired PAT with verified-bot-commit action in update workflow - Update java8-compat.sh for bzlmod jar path layout Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Konboi
commented
Jun 25, 2026
| ref: ${{ github.event.pull_request.head.ref }} | ||
| # Bot token is needed to ensure that git-push triggers relevant workflows | ||
| # See https://github.com/orgs/community/discussions/27146 | ||
| token: ${{ secrets.LAUNCHABLEINC_CI_GITHUB_TOKEN }} |
Contributor
Author
There was a problem hiding this comment.
It seems this token value is already expired
https://github.com/cloudbees-oss/smart-tests-cli/actions/runs/27262155507
https://github.com/cloudbees-oss/smart-tests-cli/actions/workflows/update_maven_install_json.yml
So, I switched to use custom action
ono-max
approved these changes
Jun 26, 2026
| @@ -0,0 +1,34 @@ | |||
| module( | |||
| name = "smart_tests_cli", | |||
Contributor
There was a problem hiding this comment.
Nit: I guess it's launchable because it's CLI v1?
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verified-bot-commitaction usingGITHUB_TOKENjava8-compat.shfor bzlmod jar path layoutChanges
.bazelrc: addcommon --enable_bzlmodMODULE.bazel: new — definesrules_jvm_external+ maven depsWORKSPACE: deleted (replaced by MODULE.bazel)WORKSPACE.bzlmod: empty placeholdersrc/maven_install.json: regenerated for bzlmod format.github/workflows/bazel-test.yml: trigger path update (exe_deploy check preserved).github/workflows/update_maven_install_json.yml: trigger path + verified-bot-commitjava8-compat.sh: support bzlmod external jar pathTest plan
🤖 Generated with Claude Code