Retry failed gitea tools updates - #852
Merged
Merged
Conversation
The giteaUpdateLoop skipped the update whenever metadataURL or useInternal differed from the last successful update, even if giteaToolsUpdateDeadline passed. When the initial fetch failed, this resulted in the tools never being fetched, as oldMetadataURL/oldUseInternal are only assigned after the first successful fetch. The condition missed a proper application of De Morgan's law. The condition is right further up in the function where it isn't negated. The intended logic is "fetch when stale OR the URL changed OR the internal flag flipped". Signed-off-by: Paul Meyer <katexochen0@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The giteaUpdateLoop skipped the update whenever metadataURL or useInternal differed from the last successful update, even if giteaToolsUpdateDeadline passed. When the initial fetch failed, this resulted in the tools never being fetched, as oldMetadataURL/oldUseInternal are only assigned after the first successful fetch.
The condition missed a proper application of De Morgan's law. The condition is right further up in the function where it isn't negated. The intended logic is "fetch when stale OR the URL changed OR the internal flag flipped".