wsman: avoid logging passwords - #502
Merged
Dany9966 merged 1 commit intoAug 19, 2026
Merged
Conversation
The WSMAN (WinRM) connection info is expected to contain sensitive data, such as passwords or key certificates. For this reason, it shouldn't be logged. There's a subsequent log message covering the host and port, which should be enough.
petrutlucian94
force-pushed
the
avoid_logging_passwords
branch
from
August 19, 2026 13:21
6cb2384 to
95d9b9d
Compare
fabi200123
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WSMAN (WinRM) connection info is expected to contain sensitive data, such as passwords or key certificates.
For this reason, it shouldn't be logged. There's a subsequent log message covering the host and port, which should be enough.